Skip to content

Commit abf7e4d

Browse files
php-coderphp-coder
committed
perf: don't open a main page just to open something, open a page that we will need instead.
Prior this change, we were opening a main page with "Open Browser" keyword and we were navigating to a required page after that. Most of the time, the next page was a login page. Now we opening desired page from the beginning. This reduces number of extra actions and speed ups the integration tests. On my Mac they are now being executed on 5 seconds faster. No functional changes.
1 parent c216ac4 commit abf7e4d

26 files changed

+27
-29
lines changed

‎src/test/robotframework/account/activation/logic.robot

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ Activate account with only required info (fill only mandatory fields)
2929

3030
*** Keywords ***
3131
Before Test Suite
32-
Open Browser ${SITE_URL} ${BROWSER}
32+
Open Browser ${SITE_URL}/account/activate ${BROWSER}
3333
Register Keyword To Run On Failure Log Source
3434

3535
Before Test

‎src/test/robotframework/account/activation/misc.robot

+1-2
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,8 @@ Password with allowed characters should be accepted
5353

5454
*** Keywords ***
5555
Before Test Suite
56-
Open Browser ${SITE_URL} ${BROWSER}
56+
Open Browser ${SITE_URL}/account/activate ${BROWSER}
5757
Register Keyword To Run On Failure Log Source
58-
Go To ${SITE_URL}/account/activate
5958

6059
After Test Suite
6160
Close Browser

‎src/test/robotframework/account/activation/validation.robot

+1-2
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,8 @@ Activate account with wrong activation key
100100

101101
*** Keywords ***
102102
Before Test Suite
103-
Open Browser ${SITE_URL} ${BROWSER}
103+
Open Browser ${SITE_URL}/account/activate ${BROWSER}
104104
Register Keyword To Run On Failure Log Source
105-
Go To ${SITE_URL}/account/activate
106105

107106
After Test Suite
108107
Close Browser

‎src/test/robotframework/auth.steps.robot

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ Documentation Common steps for login/logout of a user
44
*** Keywords ***
55
Log In As
66
[Documentation] Log in as a user
7-
[Arguments] ${login} ${password}
8-
Go To ${SITE_URL}/account/auth
7+
[Arguments] ${login} ${password} ${openPage}=${false}
8+
Run Keyword If ${openPage} Go To ${SITE_URL}/account/auth
99
Input Text id=login ${login}
1010
Input Password id=password ${password}
1111
Submit Form id=auth-account-form

‎src/test/robotframework/category/creation/logic.robot

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ Create category with name in English and Russian
3232

3333
*** Keywords ***
3434
Before Test Suite
35-
Open Browser ${SITE_URL} ${BROWSER}
35+
Open Browser ${SITE_URL}/account/auth ${BROWSER}
3636
Register Keyword To Run On Failure Log Source
3737
Log In As login=admin password=test
3838

‎src/test/robotframework/category/creation/misc.robot

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ Category name in Russian should accept all allowed characters
3737

3838
*** Keywords ***
3939
Before Test Suite
40-
Open Browser ${SITE_URL} ${BROWSER}
40+
Open Browser ${SITE_URL}/account/auth ${BROWSER}
4141
Register Keyword To Run On Failure Log Source
4242
Log In As login=admin password=test
4343
Go To ${SITE_URL}/category/add

‎src/test/robotframework/category/creation/validation.robot

+1-1
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ Create category with non-existing name but existing (non-unique) slug
8686

8787
*** Keywords ***
8888
Before Test Suite
89-
Open Browser ${SITE_URL} ${BROWSER}
89+
Open Browser ${SITE_URL}/account/auth ${BROWSER}
9090
Register Keyword To Run On Failure Log Source
9191
Log In As login=admin password=test
9292
Go To ${SITE_URL}/category/add

‎src/test/robotframework/collection/add-series/validation.robot

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Add a series with too many number of stamps
2525

2626
*** Keywords ***
2727
Before Test Suite
28-
Open Browser ${SITE_URL} ${BROWSER}
28+
Open Browser ${SITE_URL}/account/auth ${BROWSER}
2929
Register Keyword To Run On Failure Log Source
3030
Log In As login=coder password=test
3131
# We need a series with more than 1 stamp, so the number-of-stamps field won't be hidden.

‎src/test/robotframework/country/creation/logic.robot

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ Create country with name in English and Russian
3030

3131
*** Keywords ***
3232
Before Test Suite
33-
Open Browser ${SITE_URL} ${BROWSER}
33+
Open Browser ${SITE_URL}/account/auth ${BROWSER}
3434
Register Keyword To Run On Failure Log Source
3535
Log In As login=admin password=test
3636

‎src/test/robotframework/country/creation/misc.robot

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ Country name in Russian should accept all allowed characters
3737

3838
*** Keywords ***
3939
Before Test Suite
40-
Open Browser ${SITE_URL} ${BROWSER}
40+
Open Browser ${SITE_URL}/account/auth ${BROWSER}
4141
Register Keyword To Run On Failure Log Source
4242
Log In As login=admin password=test
4343
Go To ${SITE_URL}/country/add

‎src/test/robotframework/country/creation/validation.robot

+1-1
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ Create country with forbidden names
8686

8787
*** Keywords ***
8888
Before Test Suite
89-
Open Browser ${SITE_URL} ${BROWSER}
89+
Open Browser ${SITE_URL}/account/auth ${BROWSER}
9090
Register Keyword To Run On Failure Log Source
9191
Log In As login=admin password=test
9292
Go To ${SITE_URL}/country/add

‎src/test/robotframework/participant/creation/logic.robot

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ Create participant with full info (fill all fields)
3737

3838
*** Keywords ***
3939
Before Test Suite
40-
Open Browser ${SITE_URL} ${BROWSER}
40+
Open Browser ${SITE_URL}/account/auth ${BROWSER}
4141
Register Keyword To Run On Failure Log Source
4242
Log In As login=admin password=test
4343

‎src/test/robotframework/participant/creation/misc.robot

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ Name and url should be stripped from leading and trailing spaces
1717

1818
*** Keywords ***
1919
Before Test Suite
20-
Open Browser ${SITE_URL} ${BROWSER}
20+
Open Browser ${SITE_URL}/account/auth ${BROWSER}
2121
Register Keyword To Run On Failure Log Source
2222
Log In As login=admin password=test
2323
Go To ${SITE_URL}/participant/add

‎src/test/robotframework/participant/creation/validation.robot

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ Create participant with invalid url
3131

3232
*** Keywords ***
3333
Before Test Suite
34-
Open Browser ${SITE_URL} ${BROWSER}
34+
Open Browser ${SITE_URL}/account/auth ${BROWSER}
3535
Register Keyword To Run On Failure Log Source
3636
Log In As login=admin password=test
3737
Go To ${SITE_URL}/participant/add

‎src/test/robotframework/series/add-image/logic.robot

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Add additional image by downloading a file from URL
2424

2525
*** Keywords ***
2626
Before Test Suite
27-
Open Browser ${SITE_URL} ${BROWSER}
27+
Open Browser ${SITE_URL}/account/auth ${BROWSER}
2828
Register Keyword To Run On Failure Log Source
2929
Log In As login=admin password=test
3030

‎src/test/robotframework/series/add-image/validation.robot

+1-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ Add image with URL to a file of unsupported type (not an image)
5656

5757
*** Keywords ***
5858
Before Test Suite
59-
Open Browser ${SITE_URL} ${BROWSER}
59+
Open Browser ${SITE_URL}/account/auth ${BROWSER}
6060
Register Keyword To Run On Failure Log Source
6161
Log In As login=admin password=test
6262
Go To ${SITE_URL}/series/1

‎src/test/robotframework/series/creation/logic.robot

+1-1
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ Create series by filling all fields
7878

7979
*** Keywords ***
8080
Before Test Suite
81-
Open Browser ${SITE_URL} ${BROWSER}
81+
Open Browser ${SITE_URL}/account/auth ${BROWSER}
8282
Register Keyword To Run On Failure Log Source
8383
Log In As login=admin password=test
8484

‎src/test/robotframework/series/creation/misc.robot

+1-1
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ Comment should be stripped from leading and trailing spaces
9393

9494
*** Keywords ***
9595
Before Test Suite
96-
Open Browser ${SITE_URL} ${BROWSER}
96+
Open Browser ${SITE_URL}/account/auth ${BROWSER}
9797
Register Keyword To Run On Failure Log Source
9898
Log In As login=admin password=test
9999
Go To ${SITE_URL}/series/add

‎src/test/robotframework/series/creation/validation-admin.robot

+1-1
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ Create series with too long comment
101101

102102
*** Keywords ***
103103
Before Test Suite
104-
Open Browser ${SITE_URL} ${BROWSER}
104+
Open Browser ${SITE_URL}/account/auth ${BROWSER}
105105
Register Keyword To Run On Failure Log Source
106106
Log In As login=admin password=test
107107
Go To ${SITE_URL}/series/add

‎src/test/robotframework/series/creation/validation-user.robot

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Create series with empty required fields
1616

1717
*** Keywords ***
1818
Before Test Suite
19-
Open Browser ${SITE_URL} ${BROWSER}
19+
Open Browser ${SITE_URL}/account/auth ${BROWSER}
2020
Register Keyword To Run On Failure Log Source
2121
Log In As login=coder password=test
2222
Go To ${SITE_URL}/series/add

‎src/test/robotframework/series/import/request-logic.robot

+1-1
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ Submit a request with a document that couldn't be parsed
143143

144144
*** Keywords ***
145145
Before Test Suite
146-
Open Browser ${SITE_URL} ${BROWSER}
146+
Open Browser ${SITE_URL}/account/auth ${BROWSER}
147147
Register Keyword To Run On Failure Log Source
148148
Log In As login=admin password=test
149149

‎src/test/robotframework/series/import/validation.robot

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Submit request with invalid url
2424

2525
*** Keywords ***
2626
Before Test Suite
27-
Open Browser ${SITE_URL} ${BROWSER}
27+
Open Browser ${SITE_URL}/account/auth ${BROWSER}
2828
Register Keyword To Run On Failure Log Source
2929
Log In As login=admin password=test
3030
Go To ${SITE_URL}/series/import/request

‎src/test/robotframework/series/sales/misc.robot

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Url should be stripped from leading and trailing spaces
1515

1616
*** Keywords ***
1717
Before Test Suite
18-
Open Browser ${SITE_URL} ${BROWSER}
18+
Open Browser ${SITE_URL}/account/auth ${BROWSER}
1919
Register Keyword To Run On Failure Log Source
2020
Log In As login=admin password=test
2121
Go To ${SITE_URL}/series/1

‎src/test/robotframework/series/sales/validation.robot

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ Create series sales with invalid url
2020

2121
*** Keywords ***
2222
Before Test Suite
23-
Open Browser ${SITE_URL} ${BROWSER}
23+
Open Browser ${SITE_URL}/account/auth ${BROWSER}
2424
Register Keyword To Run On Failure Log Source
2525
Log In As login=admin password=test
2626
Go To ${SITE_URL}/series/1

‎src/test/robotframework/site/misc-admin.robot

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ Admin should see a link for listing categories
3737

3838
*** Keywords ***
3939
Before Test Suite
40-
Open Browser ${SITE_URL} ${BROWSER}
40+
Open Browser ${SITE_URL}/account/auth ${BROWSER}
4141
Register Keyword To Run On Failure Log Source
4242
Log In As login=admin password=test
4343
Go To ${SITE_URL}/

‎src/test/robotframework/site/misc-user.robot

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ User should not see a link to a list of import requests
1717

1818
*** Keywords ***
1919
Before Test Suite
20-
Open Browser ${SITE_URL} ${BROWSER}
20+
Open Browser ${SITE_URL}/account/auth ${BROWSER}
2121
Register Keyword To Run On Failure Log Source
2222
Log In As login=coder password=test
2323
Go To ${SITE_URL}/

0 commit comments

Comments
 (0)