refactor(RowMappers): move row mappers for the ru.mystamps.web.feature.account package to this package.

Addressed to #927

No functional changes.

Author: php-coder

src/main/java/ru/mystamps/web/feature/account/JdbcUserDao.java

@@ -33,8 +33,6 @@
 
 import lombok.RequiredArgsConstructor;
 
-import ru.mystamps.web.support.jdbc.RowMappers;
-
 @RequiredArgsConstructor
 public class JdbcUserDao implements UserDao {
 

src/main/java/ru/mystamps/web/feature/account/JdbcUsersActivationDao.java

@@ -30,8 +30,6 @@
 
 import lombok.RequiredArgsConstructor;
 
-import ru.mystamps.web.support.jdbc.RowMappers;
-
 @SuppressWarnings("PMD.AvoidDuplicateLiterals")
 @RequiredArgsConstructor
 public class JdbcUsersActivationDao implements UsersActivationDao {

src/main/java/ru/mystamps/web/feature/account/RowMappers.java

@@ -0,0 +1,62 @@
+/*
+ * Copyright (C) 2009-2018 Slava Semushin <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ */
+package ru.mystamps.web.feature.account;
+
+import java.sql.ResultSet;
+import java.sql.SQLException;
+
+// this class only for this package
+@SuppressWarnings("PMD.DefaultPackage")
+final class RowMappers {
+	
+	private RowMappers() {
+	}
+		
+	/* default */ static UsersActivationDto forUsersActivationDto(ResultSet rs, int unused)
+		throws SQLException {
+		
+		return new UsersActivationDto(
+			rs.getString("email"),
+			rs.getTimestamp("created_at")
+		);
+	}
+	
+	/* default */ static UsersActivationFullDto forUsersActivationFullDto(ResultSet rs, int unused)
+		throws SQLException {
+		
+		return new UsersActivationFullDto(
+			rs.getString("activation_key"),
+			rs.getString("email"),
+			rs.getTimestamp("created_at")
+		);
+	}
+	
+	/* default */ static UserDetails forUserDetails(ResultSet rs, int unused)
+		throws SQLException {
+		
+		return new UserDetails(
+			rs.getInt("id"),
+			rs.getString("login"),
+			rs.getString("name"),
+			rs.getString("hash"),
+			UserDetails.Role.valueOf(rs.getString("role")),
+			rs.getString("collection_slug")
+		);
+	}
+	
+}

src/main/java/ru/mystamps/web/support/jdbc/RowMappers.java

@@ -24,9 +24,6 @@
 
 // CheckStyle: ignore AvoidStarImportCheck for next 1 line
 import ru.mystamps.web.dao.dto.*; // NOPMD: UnusedImports
-import ru.mystamps.web.feature.account.UserDetails;
-import ru.mystamps.web.feature.account.UsersActivationDto;
-import ru.mystamps.web.feature.account.UsersActivationFullDto;
 import ru.mystamps.web.feature.collection.CollectionInfoDto;
 import ru.mystamps.web.feature.collection.SeriesInCollectionDto;
 import ru.mystamps.web.feature.collection.SeriesInCollectionWithPriceDto;
@@ -262,25 +259,6 @@ public static SuspiciousActivityDto forSuspiciousActivityDto(ResultSet rs, int u
 			userAgent
 		);
 	}
-		
-	public static UsersActivationDto forUsersActivationDto(ResultSet rs, int unused)
-		throws SQLException {
-		
-		return new UsersActivationDto(
-			rs.getString("email"),
-			rs.getTimestamp("created_at")
-		);
-	}
-	
-	public static UsersActivationFullDto forUsersActivationFullDto(ResultSet rs, int unused)
-		throws SQLException {
-		
-		return new UsersActivationFullDto(
-			rs.getString("activation_key"),
-			rs.getString("email"),
-			rs.getTimestamp("created_at")
-		);
-	}
 
 	public static CollectionInfoDto forCollectionInfoDto(ResultSet rs, int unused)
 		throws SQLException {
@@ -292,17 +270,6 @@ public static CollectionInfoDto forCollectionInfoDto(ResultSet rs, int unused)
 		);
 	}
 
-	public static UserDetails forUserDetails(ResultSet rs, int unused) throws SQLException {
-		return new UserDetails(
-			rs.getInt("id"),
-			rs.getString("login"),
-			rs.getString("name"),
-			rs.getString("hash"),
-			UserDetails.Role.valueOf(rs.getString("role")),
-			rs.getString("collection_slug")
-		);
-	}
-	
 	public static EntityWithIdDto forEntityWithIdDto(ResultSet rs, int unused) throws SQLException {
 		return new EntityWithIdDto(
 			rs.getInt("id"),