SeriesServiceImpl.findByZagorskiNumber(): add unit tests.

Fix #810

Author: php-coder

src/main/java/ru/mystamps/web/service/SeriesServiceImpl.java

@@ -277,7 +277,6 @@ public List<SeriesInfoDto> findBySolovyovNumber(String solovyovNumberCode, Strin
 		return findByCatalogNumber(solovyovCatalogService, solovyovNumberCode, lang);
 	}
 
-	// @todo #776 SeriesServiceImpl.findByZagorskiNumber(): add unit tests
 	@Override
 	@Transactional(readOnly = true)
 	public List<SeriesInfoDto> findByZagorskiNumber(String zagorskiNumberCode, String lang) {

src/test/groovy/ru/mystamps/web/service/SeriesServiceImplTest.groovy

@@ -1113,6 +1113,45 @@ class SeriesServiceImplTest extends Specification {
 			result == expectedResult
 	}
 
+	//
+	// Tests for findByZagorskiNumber()
+	//
+	
+	def 'findByZagorskiNumber() should find series ids'() {
+		given:
+			String expectedNumber = Random.catalogNumber()
+		when:
+			service.findByZagorskiNumber(expectedNumber, Random.lang())
+		then:
+			1 * zagorskiCatalogService.findSeriesIdsByNumber(expectedNumber) >> []
+	}
+	
+	def 'findByZagorskiNumber() shouldn\'t try to find series info if there are no series'() {
+		given:
+			zagorskiCatalogService.findSeriesIdsByNumber(_ as String) >> []
+		when:
+			List<SeriesInfoDto> result = service.findByZagorskiNumber(Random.catalogNumber(), Random.lang())
+		then:
+			0 * seriesDao.findByIdsAsSeriesInfo(_ as List, _ as String)
+		and:
+			result.empty
+	}
+	
+	def 'findByZagorskiNumber() should find and return series info'() {
+		given:
+			String expectedLang = Random.lang()
+			List<Integer> expectedSeriesIds = Random.listOfIntegers()
+			List<SeriesInfoDto> expectedResult = Random.listOfSeriesInfoDto()
+		and:
+			zagorskiCatalogService.findSeriesIdsByNumber(_ as String) >> expectedSeriesIds
+		when:
+			List<SeriesInfoDto> result = service.findByZagorskiNumber(Random.catalogNumber(), expectedLang)
+		then:
+			1 * seriesDao.findByIdsAsSeriesInfo(expectedSeriesIds, expectedLang) >> expectedResult
+		and:
+			result == expectedResult
+	}
+	
 	//
 	// Tests for findByCategorySlug()
 	//