SeriesServiceImpl.findBySolovyovNumber(): add unit tests.

Fix #818

Author: php-coder

src/main/java/ru/mystamps/web/service/SeriesServiceImpl.java

@@ -271,7 +271,6 @@ public List<SeriesInfoDto> findByGibbonsNumber(String gibbonsNumberCode, String
 		return findByCatalogNumber(gibbonsCatalogService, gibbonsNumberCode, lang);
 	}
 
-	// @todo #777 SeriesServiceImpl.findBySolovyovNumber(): add unit tests
 	@Override
 	@Transactional(readOnly = true)
 	public List<SeriesInfoDto> findBySolovyovNumber(String solovyovNumberCode, String lang) {

src/test/groovy/ru/mystamps/web/service/SeriesServiceImplTest.groovy

@@ -1074,6 +1074,45 @@ class SeriesServiceImplTest extends Specification {
 			result == expectedResult
 	}
 
+	//
+	// Tests for findBySolovyovNumber()
+	//
+	
+	def 'findBySolovyovNumber() should find series ids'() {
+		given:
+			String expectedNumber = Random.catalogNumber()
+		when:
+			service.findBySolovyovNumber(expectedNumber, Random.lang())
+		then:
+			1 * solovyovCatalogService.findSeriesIdsByNumber(expectedNumber) >> []
+	}
+	
+	def 'findBySolovyovNumber() shouldn\'t try to find series info if there are no series'() {
+		given:
+			solovyovCatalogService.findSeriesIdsByNumber(_ as String) >> []
+		when:
+			List<SeriesInfoDto> result = service.findBySolovyovNumber(Random.catalogNumber(), Random.lang())
+		then:
+			0 * seriesDao.findByIdsAsSeriesInfo(_ as List, _ as String)
+		and:
+			result.empty
+	}
+	
+	def 'findBySolovyovNumber() should find and return series info'() {
+		given:
+			String expectedLang = Random.lang()
+			List<Integer> expectedSeriesIds = Random.listOfIntegers()
+			List<SeriesInfoDto> expectedResult = Random.listOfSeriesInfoDto()
+		and:
+			solovyovCatalogService.findSeriesIdsByNumber(_ as String) >> expectedSeriesIds
+		when:
+			List<SeriesInfoDto> result = service.findBySolovyovNumber(Random.catalogNumber(), expectedLang)
+		then:
+			1 * seriesDao.findByIdsAsSeriesInfo(expectedSeriesIds, expectedLang) >> expectedResult
+		and:
+			result == expectedResult
+	}
+	
 	//
 	// Tests for findByCategorySlug()
 	//

src/test/java/ru/mystamps/web/tests/Random.java

@@ -37,6 +37,7 @@
 import ru.mystamps.web.dao.dto.EntityWithIdDto;
 import ru.mystamps.web.dao.dto.EntityWithParentDto;
 import ru.mystamps.web.dao.dto.ImportRequestFullInfo;
+import ru.mystamps.web.dao.dto.SeriesInfoDto;
 import ru.mystamps.web.service.TestObjects;
 import ru.mystamps.web.validation.ValidationRules;
 
@@ -224,6 +225,18 @@ public static List<EntityWithParentDto> listOfEntityWithParentDto() {
 		);
 	}
 
+	public static List<SeriesInfoDto> listOfSeriesInfoDto() {
+		final int minSize = 1;
+		final int maxSize = 3;
+		int size = integer(minSize, maxSize);
+		return sampleMultiple(
+			size,
+			TestObjects.createSeriesInfoDto(),
+			TestObjects.createSeriesInfoDto(),
+			TestObjects.createSeriesInfoDto()
+		);
+	}
+	
 	public static List<ImportRequestFullInfo> listOfImportRequestFullInfo() {
 		final int minSize = 1;
 		final int maxSize = 3;