Revert "JdbcUtils: fix (instead of ignoring) PMD warning about premature variable declaration."

php-coder · php-coder · commit 2996647285aa · 2016-07-25T22:47:35.000+02:00
This reverts commit 33e9e14. Fix #419
diff --git a/src/main/java/ru/mystamps/web/dao/impl/JdbcUtils.java b/src/main/java/ru/mystamps/web/dao/impl/JdbcUtils.java
@@ -26,12 +26,13 @@ private JdbcUtils() {
 	}
 	
 	// @see http://stackoverflow.com/q/2920364/checking-for-a-null-int-value-from-a-java-resultset
+	@SuppressWarnings("PMD.PrematureDeclaration")
 	public static Integer getInteger(ResultSet resultSet, String fieldName) throws SQLException {
+		int value = resultSet.getInt(fieldName);
 		if (resultSet.wasNull()) {
 			return null;
 		}
 		
-		int value = resultSet.getInt(fieldName);
 		return Integer.valueOf(value);
 	}
 	

Original file line number	Diff line number	Diff line change
`@@ -26,12 +26,13 @@ private JdbcUtils() {`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`// @see http://stackoverflow.com/q/2920364/checking-for-a-null-int-value-from-a-java-resultset`
	`29`	`+ @SuppressWarnings("PMD.PrematureDeclaration")`
`29`	`30`	`public static Integer getInteger(ResultSet resultSet, String fieldName) throws SQLException {`
	`31`	`+ int value = resultSet.getInt(fieldName);`
`30`	`32`	`if (resultSet.wasNull()) {`
`31`	`33`	`return null;`
`32`	`34`	`}`
`33`	`35`
`34`		`- int value = resultSet.getInt(fieldName);`
`35`	`36`	`return Integer.valueOf(value);`
`36`	`37`	`}`
`37`	`38`