JdbcUtils: fix (instead of ignoring) PMD warning about premature variable declaration.

php-coder · php-coder · commit 33e9e146b154 · 2016-07-17T16:53:43.000+02:00
Should be in 5caa57c commit. No functional changes.
diff --git a/src/main/java/ru/mystamps/web/dao/impl/JdbcUtils.java b/src/main/java/ru/mystamps/web/dao/impl/JdbcUtils.java
@@ -26,13 +26,12 @@ private JdbcUtils() {
 	}
 	
 	// @see http://stackoverflow.com/q/2920364/checking-for-a-null-int-value-from-a-java-resultset
-	@SuppressWarnings("PMD.PrematureDeclaration")
 	public static Integer getInteger(ResultSet resultSet, String fieldName) throws SQLException {
-		int value = resultSet.getInt(fieldName);
 		if (resultSet.wasNull()) {
 			return null;
 		}
 		
+		int value = resultSet.getInt(fieldName);
 		return Integer.valueOf(value);
 	}
 	

Original file line number	Diff line number	Diff line change
`@@ -26,13 +26,12 @@ private JdbcUtils() {`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`// @see http://stackoverflow.com/q/2920364/checking-for-a-null-int-value-from-a-java-resultset`
`29`		`- @SuppressWarnings("PMD.PrematureDeclaration")`
`30`	`29`	`public static Integer getInteger(ResultSet resultSet, String fieldName) throws SQLException {`
`31`		`- int value = resultSet.getInt(fieldName);`
`32`	`30`	`if (resultSet.wasNull()) {`
`33`	`31`	`return null;`
`34`	`32`	`}`
`35`	`33`
	`34`	`+ int value = resultSet.getInt(fieldName);`
`36`	`35`	`return Integer.valueOf(value);`
`37`	`36`	`}`
`38`	`37`