fix(validation): URL for import must be supported by one of the site parsers.

Fix #690 (/series/import/request page)
Fix #1027 (series sale import form on /series/{id} page)

Author: php-coder

src/main/java/ru/mystamps/web/feature/series/importing/HasSiteParser.java

@@ -0,0 +1,44 @@
+/*
+ * Copyright (C) 2009-2019 Slava Semushin <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ */
+package ru.mystamps.web.feature.series.importing;
+
+import javax.validation.Constraint;
+import javax.validation.Payload;
+import java.lang.annotation.Documented;
+import java.lang.annotation.Retention;
+import java.lang.annotation.Target;
+
+import static java.lang.annotation.ElementType.ANNOTATION_TYPE;
+import static java.lang.annotation.ElementType.FIELD;
+import static java.lang.annotation.ElementType.METHOD;
+import static java.lang.annotation.RetentionPolicy.RUNTIME;
+
+// @todo #690 Series import: add integration test to check that URL can be parsed
+// @todo #1027 Series sale import: add integration test to check that URL can be parsed
+/**
+ * Validates that the URL can be parsed by one of the site parsers.
+ */
+@Target({ METHOD, FIELD, ANNOTATION_TYPE })
+@Retention(RUNTIME)
+@Constraint(validatedBy = HasSiteParserValidator.class)
+@Documented
+public @interface HasSiteParser {
+	String message() default "{ru.mystamps.web.feature.series.importing.HasSiteParser.message}";
+	Class<?>[] groups() default {};
+	Class<? extends Payload>[] payload() default {};
+}

src/main/java/ru/mystamps/web/feature/series/importing/HasSiteParserValidator.java

@@ -0,0 +1,47 @@
+/*
+ * Copyright (C) 2009-2019 Slava Semushin <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ */
+package ru.mystamps.web.feature.series.importing;
+
+import lombok.RequiredArgsConstructor;
+import ru.mystamps.web.feature.series.importing.extractor.SiteParserService;
+
+import javax.validation.ConstraintValidator;
+import javax.validation.ConstraintValidatorContext;
+
+@RequiredArgsConstructor
+public class HasSiteParserValidator implements ConstraintValidator<HasSiteParser, String> {
+	
+	private final SiteParserService siteParserService;
+	
+	@Override
+	public void initialize(HasSiteParser annotation) {
+		// Intentionally empty: nothing to initialize
+	}
+
+	@Override
+	public boolean isValid(String value, ConstraintValidatorContext ctx) {
+		
+		if (value == null) {
+			return true;
+		}
+		
+		// @todo #690 HasSiteParserValidator: introduce SiteParserService.hasParserForUrl()
+		return siteParserService.findForUrl(value) != null;
+	}
+	
+}

src/main/java/ru/mystamps/web/feature/series/importing/RequestImportForm.java

@@ -32,12 +32,12 @@
 	RequestImportForm.class,
 	Group.Level1.class,
 	Group.Level2.class,
-	Group.Level3.class
+	Group.Level3.class,
+	Group.Level4.class
 })
 public class RequestImportForm implements RequestImportDto {
 
 	// @todo #995 Series sale import: use its own interface and form
-	// @todo #995 /series/sales/import: validate that we have a parser for this url
 	@NotEmpty(groups = Group.Level1.class)
 	@Size(
 		// For series sales a max length is SERIES_SALES_URL_MAX_LENGTH but since they are equal,
@@ -49,5 +49,6 @@ public class RequestImportForm implements RequestImportDto {
 		groups = Group.Level2.class
 	)
 	@URL(groups = Group.Level3.class)
+	@HasSiteParser(groups = Group.Level4.class)
 	private String url;
 }

src/main/resources/ru/mystamps/i18n/ValidationMessages.properties

@@ -28,6 +28,7 @@ ru.mystamps.web.feature.country.UniqueCountryName.message = Country already exis
 ru.mystamps.web.feature.country.UniqueCountrySlug.message = Country with similar name already exists
 ru.mystamps.web.feature.series.ReleaseDateIsNotInFuture.message = Release date must not be in future
 ru.mystamps.web.feature.series.RequireImageOrImageUrl.message = Image or image URL must be specified
+ru.mystamps.web.feature.series.importing.HasSiteParser.message = Import from this site isn't supported
 
 ru.mystamps.web.feature.series.DownloadResult.INVALID_URL = Invalid URL
 ru.mystamps.web.feature.series.DownloadResult.INVALID_REDIRECT = URL must not redirect to another address

src/main/resources/ru/mystamps/i18n/ValidationMessages_ru.properties

@@ -28,6 +28,7 @@ ru.mystamps.web.feature.country.UniqueCountryName.message = Страна уже
 ru.mystamps.web.feature.country.UniqueCountrySlug.message = Страна с похожим названием уже есть в базе
 ru.mystamps.web.feature.series.ReleaseDateIsNotInFuture.message = Дата выпуска не может быть в будущем
 ru.mystamps.web.feature.series.RequireImageOrImageUrl.message = Необходимо выбрать изображение либо указать ссылку на него
+ru.mystamps.web.feature.series.importing.HasSiteParser.message = Импорт с данного сайта не поддерживается
 
 ru.mystamps.web.feature.series.DownloadResult.INVALID_URL = Неправильный URL
 ru.mystamps.web.feature.series.DownloadResult.INVALID_REDIRECT = URL не должен перенаправлять на другой адрес