Skip to content

Commit 0bc9d1b

Browse files
committed
refactor: remove unused TestObjects.listOfImportRequestFullInfo() method
Should be in db5a330 commit. The following issue won't be fixed: Closes #746 Part of #1668
1 parent 2dc626b commit 0bc9d1b

File tree

2 files changed

+0
-38
lines changed

2 files changed

+0
-38
lines changed

src/test/java/ru/mystamps/web/service/TestObjects.java

-10
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
import ru.mystamps.web.feature.image.ImageInfoDto;
2929
import ru.mystamps.web.feature.participant.EntityWithIdDto;
3030
import ru.mystamps.web.feature.series.SeriesInfoDto;
31-
import ru.mystamps.web.feature.series.importing.ImportRequestFullInfo;
3231
import ru.mystamps.web.feature.series.importing.sale.SeriesSaleParsedDataDto;
3332
import ru.mystamps.web.feature.series.importing.sale.SeriesSalesParsedDataDbDto;
3433
import ru.mystamps.web.feature.site.SuspiciousActivityDto;
@@ -150,15 +149,6 @@ public static EntityWithParentDto createEntityWithParentDto() {
150149
return new EntityWithParentDto(Random.id().toString(), name, parentName);
151150
}
152151

153-
public static ImportRequestFullInfo createImportRequestFullInfo() {
154-
return new ImportRequestFullInfo(
155-
Random.id(),
156-
Random.url(),
157-
Random.importRequestStatus(),
158-
Random.date()
159-
);
160-
}
161-
162152
public static SeriesSalesParsedDataDbDto createSeriesSalesParsedDataDbDto() {
163153
SeriesSalesParsedDataDbDto dto = new SeriesSalesParsedDataDbDto();
164154

src/test/java/ru/mystamps/web/tests/Random.java

-28
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@
3030
import ru.mystamps.web.feature.participant.ParticipantValidation;
3131
import ru.mystamps.web.feature.series.SeriesInfoDto;
3232
import ru.mystamps.web.feature.series.SeriesValidation;
33-
import ru.mystamps.web.feature.series.importing.ImportRequestFullInfo;
34-
import ru.mystamps.web.feature.series.importing.SeriesImportDb.SeriesImportRequestStatus;
3533
import ru.mystamps.web.feature.series.sale.SeriesCondition;
3634
import ru.mystamps.web.feature.site.SiteUrl;
3735
import ru.mystamps.web.service.TestObjects;
@@ -59,16 +57,6 @@
5957

6058
public final class Random {
6159

62-
// @todo #687 Random.STATUSES: reduce duplication by using EnumSet.allOf()
63-
private static final String[] STATUSES = new String[] {
64-
SeriesImportRequestStatus.UNPROCESSED,
65-
SeriesImportRequestStatus.DOWNLOADING_SUCCEEDED,
66-
SeriesImportRequestStatus.DOWNLOADING_FAILED,
67-
SeriesImportRequestStatus.PARSING_SUCCEEDED,
68-
SeriesImportRequestStatus.PARSING_FAILED,
69-
SeriesImportRequestStatus.IMPORT_SUCCEEDED,
70-
};
71-
7260
private Random() {
7361
}
7462

@@ -215,10 +203,6 @@ public static boolean perforated() {
215203
return bool();
216204
}
217205

218-
public static String importRequestStatus() {
219-
return sample(STATUSES);
220-
}
221-
222206
public static Set<String> solovyovNumbers() {
223207
return catalogNumbers();
224208
}
@@ -282,18 +266,6 @@ public static List<SeriesInfoDto> listOfSeriesInfoDto() {
282266
);
283267
}
284268

285-
public static List<ImportRequestFullInfo> listOfImportRequestFullInfo() {
286-
final int minSize = 1;
287-
final int maxSize = 3;
288-
int size = integer(minSize, maxSize);
289-
return sampleMultiple(
290-
size,
291-
TestObjects.createImportRequestFullInfo(),
292-
TestObjects.createImportRequestFullInfo(),
293-
TestObjects.createImportRequestFullInfo()
294-
);
295-
}
296-
297269
public static String jsoupLocator() {
298270
return sample("#id", "a[href]", "img[src$=.png]", "div#logo");
299271
}

0 commit comments

Comments
 (0)