Skip to content

Commit db5a330

Browse files
committed
test: remove most of the tests for SeriesImportServiceImpl class
The following issue won't be fixed: Closes #757 Closes #902 Closes #923 Closes #1271 Closes #1430 Part of #1668
1 parent 85f1ec4 commit db5a330

File tree

3 files changed

+0
-717
lines changed

3 files changed

+0
-717
lines changed

src/main/java/ru/mystamps/web/feature/series/importing/SeriesImportServiceImpl.java

-5
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,6 @@ public void saveParsedData(Integer requestId, SeriesExtractedInfo seriesInfo, Li
194194
seriesParsedData.setQuantity(seriesInfo.getQuantity());
195195
seriesParsedData.setPerforated(seriesInfo.getPerforated());
196196

197-
// @todo #694 SeriesImportServiceImpl.saveParsedData(): add unit tests for michel numbers
198197
Set<String> michelNumbers = seriesInfo.getMichelNumbers();
199198
if (!michelNumbers.isEmpty()) {
200199
String shortenedNumbers = CatalogUtils.toShortForm(michelNumbers);
@@ -207,7 +206,6 @@ public void saveParsedData(Integer requestId, SeriesExtractedInfo seriesInfo, Li
207206
seriesParsedData.setMichelNumbers(shortenedNumbers);
208207
}
209208

210-
// @todo #857 SeriesImportServiceImpl.saveParsedData(): add unit test for seller group
211209
SeriesSalesParsedDataDbDto seriesSalesParsedData = new SeriesSalesParsedDataDbDto();
212210
seriesSalesParsedData.setCreatedAt(now);
213211
seriesSalesParsedData.setUpdatedAt(now);
@@ -222,15 +220,12 @@ public void saveParsedData(Integer requestId, SeriesExtractedInfo seriesInfo, Li
222220
seriesSalesParsedData.setCurrency(seriesInfo.getCurrency());
223221
}
224222

225-
// @todo #1230 SeriesImportServiceImpl.saveParsedData():
226-
// add unit test for alternative price and currency
227223
BigDecimal altPrice = seriesInfo.getAltPrice();
228224
if (altPrice != null) {
229225
seriesSalesParsedData.setAltPrice(altPrice);
230226
seriesSalesParsedData.setAltCurrency(seriesInfo.getAltCurrency());
231227
}
232228

233-
// @todo #1326 SeriesImportServiceImpl.saveParsedData(): add unit test for condition
234229
SeriesCondition condition = seriesInfo.getCondition();
235230
if (condition != null) {
236231
seriesSalesParsedData.setCondition(condition.toString());

0 commit comments

Comments
 (0)