Skip to content

Commit 00e046e

Browse files
committed
refactor: make add year form more compact
Fix #1454
1 parent 7c6e1a1 commit 00e046e

File tree

1 file changed

+26
-25
lines changed

1 file changed

+26
-25
lines changed

src/main/frontend/src/components/AddReleaseYearForm.js

Lines changed: 26 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -104,19 +104,19 @@ class AddReleaseYearFormView extends React.PureComponent {
104104
const rangeOfYears = this.generateRange(sinceYear, tillYear);
105105

106106
return (
107-
<div className="col-sm-12 form-group">
108-
<form id="add-release-year-form" className={ `form-horizontal ${hasValidationErrors ? 'has-error' : ''}` }
109-
onSubmit={ handleSubmit }>
110-
<div
111-
id="add-release-year-failed-msg"
112-
className={ `alert alert-danger text-center col-sm-8 col-sm-offset-2 ${hasServerError ? '' : 'hidden' }` }>
113-
{ l10n['t_server_error'] || 'Server error' }
114-
</div>
115-
<div className="form-group form-group-sm">
107+
<div className="row">
108+
<div id="add-release-year-failed-msg"
109+
className={ `alert alert-danger text-center col-sm-8 col-sm-offset-2 ${hasServerError ? '' : 'hidden'}` }>
110+
{ l10n['t_server_error'] || 'Server error' }
111+
</div>
112+
<div className="col-sm-12">
113+
<form id="add-release-year-form"
114+
className={`form-horizontal ${hasValidationErrors ? 'has-error' : ''}`}
115+
onSubmit={ handleSubmit }>
116116
<label htmlFor="release-year" className="control-label col-sm-3">
117117
{ l10n['t_year'] || 'Year' }
118118
</label>
119-
<div className="col-sm-6">
119+
<div className="form-group form-group-sm col-sm-5">
120120
<select
121121
id="release-year"
122122
name="release-year"
@@ -128,22 +128,23 @@ class AddReleaseYearFormView extends React.PureComponent {
128128
<option key={year.toString()} value={year}>{ year }</option>
129129
))}
130130
</select>
131+
<span
132+
id="release-year.errors"
133+
className={ `help-block ${hasValidationErrors ? '' : 'hidden'}` }>
134+
{ validationErrors.join(', ') }
135+
</span>
131136
</div>
132-
</div>
133-
<div className="col-sm-offset-3 col-sm-4">
134-
<span
135-
id="release-year.errors"
136-
className={ `help-block ${hasValidationErrors ? '' : 'hidden'}` }>
137-
{ validationErrors.join(', ') }
138-
</span>
139-
<button
140-
type="submit"
141-
className="btn btn-primary btn-sm"
142-
disabled={ isDisabled }>
143-
{ l10n['t_add'] || 'Add' }
144-
</button>
145-
</div>
146-
</form>
137+
<div className="form-group form-group-sm">
138+
<button type="submit"
139+
className="btn btn-primary btn-sm"
140+
disabled={ isDisabled }>
141+
{ l10n['t_add'] || 'Add' }
142+
</button>
143+
144+
</div>
145+
146+
</form>
147+
</div>
147148
</div>
148149
);
149150
}

0 commit comments

Comments
 (0)