Add PostgisGeometryCodec #491
Conversation
| @@ -48,6 +49,8 @@ | |||
| switch (this) { | |||
| case HSTORE: | |||
| return new HStoreCodec(byteBufAllocator, oid); | |||
| case POSTGIS_GEOMETRY: | |||
There was a problem hiding this comment.
The code should include a guard to verify that the required classes for jts-core are on the class path.
There was a problem hiding this comment.
Added isSupported method and changed to register codec only when it returns true.
https://github.com/pgjdbc/r2dbc-postgresql/pull/491/files#diff-fd71b4f5bee0d344ac2efe1c099a3fc593fecfb04fd3281d340ed091fc1a39e1R101
earlbread
force-pushed
the
postgis-geometry-codec
branch
2 times, most recently
from
820140b to
7f0c10a
Compare
[resolves pgjdbc#483] Signed-off-by: Seunghun Lee <[email protected]>
earlbread
force-pushed
the
postgis-geometry-codec
branch
from
7f0c10a to
2a44b8f
Compare
|
Since |
|
Codecs aren't really used concurrently, they are rather used sequentially and each connection maintains its own codec instances. In any case, codecs might be used by different threads and that can introduce visibility issues so it's perfectly fine to maintain individual instances. |
[resolves #483][#491] Signed-off-by: Seunghun Lee <[email protected]>
[resolves #483][#491] Signed-off-by: Seunghun Lee <[email protected]>
Use this. for instance field access. Align license headers. Simplify classpath detection. [#483][closes #491] Signed-off-by: Mark Paluch <[email protected]>
|
Thank you for your contribution. That's merged, polished, and backported now. |
Make sure that:
Issue description
This supports Postgis Geometry type. #483