Skip to content

High availability cluster merge #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

High availability cluster merge #250

wants to merge 6 commits into from

Conversation

vtk
Copy link

@vtk vtk commented Feb 14, 2020

Merged conflicts for feature high-availability-cluster that was implemented by @Squiry with latest master

@pivotal-issuemaster
Copy link

@vtk Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@vtk Thank you for signing the Contributor License Agreement!

@mp911de
Copy link
Collaborator

mp911de commented Feb 14, 2020

Thanks for your effort. Creating a PR on top of another PR brings us in a weird situation as the previous PR had several comments attached and it wasn't abandoned.

@vtk
Copy link
Author

vtk commented Feb 14, 2020

Thanks for your effort. Creating a PR on top of another PR brings us in a weird situation as the previous PR had several comments attached and it wasn't abandoned.

No problem i can try to fix those comments

@mp911de
Copy link
Collaborator

mp911de commented Feb 14, 2020

@Squiry what's your opinion on this PR?

@Squiry
Copy link
Collaborator

Squiry commented Feb 14, 2020

My plan was to rewrite it from scratch since we need some more flexible mechanism of server-picking, so I'm not sure that there's any point in conflict resolving. But if we're going to keep interface as it is right now then we can continue in this PR.

@mp911de
Copy link
Collaborator

mp911de commented Feb 14, 2020

I'm also in favor of closing this PR. If you plan to rewrite yours, then probably it makes also sense to close #203 and start with a fresh PR.

@mp911de mp911de closed this Feb 14, 2020
@mp911de mp911de added the status: duplicate A duplicate of another issue label Feb 14, 2020
@mp911de
Copy link
Collaborator

mp911de commented Feb 14, 2020

Closing this PR without a merge as per the previous comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants