-
Notifications
You must be signed in to change notification settings - Fork 184
High availability cluster merge #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@vtk Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@vtk Thank you for signing the Contributor License Agreement! |
Thanks for your effort. Creating a PR on top of another PR brings us in a weird situation as the previous PR had several comments attached and it wasn't abandoned. |
No problem i can try to fix those comments |
@Squiry what's your opinion on this PR? |
My plan was to rewrite it from scratch since we need some more flexible mechanism of server-picking, so I'm not sure that there's any point in conflict resolving. But if we're going to keep interface as it is right now then we can continue in this PR. |
I'm also in favor of closing this PR. If you plan to rewrite yours, then probably it makes also sense to close #203 and start with a fresh PR. |
Closing this PR without a merge as per the previous comment. |
Merged conflicts for feature high-availability-cluster that was implemented by @Squiry with latest master