Add codec for BigInteger #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applicable to any numeric type with scale 0 [resolves pgjdbc#233]
timve
commented
Jan 29, 2020
| BigInteger doDecode(ByteBuf buffer, PostgresqlObjectId dataType, @Nullable Format format, @Nullable Class<? extends BigInteger> type) { | ||
| Assert.requireNonNull(buffer, "byteBuf must not be null"); | ||
|
|
||
| return this.decodeNumber(buffer, dataType, format, BigInteger.class, it -> new BigInteger(it.toString())); |
There was a problem hiding this comment.
This code potentially throws NumberFormatException when the scale is > 0.
I did not find any defensive code in the other subclasses of AbstractNumericCodec so I did not add checks to see if construction of the BigInteger is possible using the decoded value.
There was a problem hiding this comment.
Our codecs downcast values if they are requested to do so. E.g. a FLOAT8 column result can be consumed as Double, Long, Int etc. I think we should do the same here and return the BigInteger value.
I will take care of this aspect during the merge.
mp911de
added a commit
that referenced
this pull request
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable to any numeric type with scale 0
[resolves #233]