Fix for concurrent exchanging on one client #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
added a commit
that referenced
this pull request
Jan 22, 2020
mp911de
pushed a commit
that referenced
this pull request
Jan 22, 2020
mp911de
added a commit
that referenced
this pull request
Jan 22, 2020
|
Thanks, that's merged, polished, and backported now. We needed to backport the issue to handle parse errors (f9d0d7f) to properly backport this change to 0.8.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we send requests fast enough client can mix frames of different queries. That leads to "Unknown portal" error (when one flow send
Syncbetween othersBindandExecute) or "Source emitted more than one item" (when one flow sendSyncbetween othersExecuteandSync- its result will receiveCommandCompletefrom both queries).It can easely be fixed by changing concurrent subscribing to request
Publishers to concatmapping them.Should fix #207