Fix instant handling #196
Merged
Fix instant handling #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java's `Instant` type is a fixed point in time (unix epoch which is always UTC) and therefore similar to `OffsetDateTime`. Currently Instant is mapped to a `TIMESTAMP` which is incorrect. This commit changes this to `TIMESTAMPTZ` which is Postgres' type for specific points in time and is the same way the official driver handles this.
The current DateCodec for legacy `java.util.Date` was using `java.time.Instant` which was itself incorrectly mapping to `TIMESTAMP`. With the previous fix to `InstantCodec` the codec of `Date` had to be changed so the more correct `LocalDateTimeCodec`.
|
@bzikarsky Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@bzikarsky Thank you for signing the Contributor License Agreement! |
mp911de
approved these changes
Nov 21, 2019
There was a problem hiding this comment.
Thanks for your PR. R2DBC type conversion isn't touching Date and Instant so we have a certain degree of freedom here.
Feel free to add Instant and Date to the readme and we're good to merge this pull request.
|
Awesome! I just added the 2 types to the README. |
mp911de
added a commit
that referenced
this pull request
Nov 21, 2019
mp911de
added a commit
that referenced
this pull request
Nov 21, 2019
|
Thanks a lot. That's merged and polished now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instants were (IMO) incorrectly mapped to
TIMESTAMPon the wire. The official postgres java docs say so as well.This PR includes two commits/changes:
a) Make
InstantCodecuseTIMESTAMPTZ- this is straightforward, tests have been updated accordinglyb) Make
DateCodecnot useInstantCodecanymore and useLocalDateTimeinstead. This is a bit more involved as we have to make use of LocalDateTime handles dates without time properly and we need to do some date-object juggling in general.I guess this "breaks backwards compatibility" in a way, but as this can be considered a bug (we ran into this by accident as our test-suite just didn't want to turn green), it should still be fixed in my opinion.
If this passes the review, we could also add
Instantto the supported types on theREADME.I will also gladly sign the Contributing Agreement if this is required for this MR.