Skip to content

Interval.parse doesn't parse week #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
emilwihlander opened this issue Nov 16, 2022 · 2 comments · Fixed by #566
Closed

Interval.parse doesn't parse week #565

emilwihlander opened this issue Nov 16, 2022 · 2 comments · Fixed by #566
Labels
status: ideal-for-contribution An issue that a contributor can help us with type: bug A general bug
Milestone
1.0.1.RELEASE

Comments

@emilwihlander
Copy link
Contributor

Bug Report

Versions

  • Driver: 1.0.0.RELEASE
  • Database: 14
  • Java: 17
  • OS: macOS

Current Behavior

When trying to parse a week interval an empty (all values 0) Interval is returned.

Steps to reproduce

Interval.parse("1 week").toString() == Interval.ZERO.toString()

Expected behavior/code

That weeks are parsed as 7 days per week

Possible Solution

Additional context
@emilwihlander emilwihlander added the status: waiting-for-triage An issue we've not yet triaged label Nov 16, 2022
@emilwihlander
Copy link
Contributor Author

I have a local version supporting all additional postgresql interval units: millennium, century, decade, week. I will create a PR soon

@mp911de mp911de added type: bug A general bug status: ideal-for-contribution An issue that a contributor can help us with and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 17, 2022
@mp911de
Copy link
Collaborator

mp911de commented Nov 17, 2022

Thanks a lot, happy to review your changes.

emilwihlander pushed a commit to emilwihlander/r2dbc-postgresql that referenced this issue Nov 17, 2022
@emil-wihlander-zynka
Implement support for interval units.
3b4639e 
[pgjdbc#565]
@emilwihlander emilwihlander mentioned this issue Nov 17, 2022
Merged
4 tasks
@mp911de mp911de closed this as completed in c889796 Dec 7, 2022
mp911de pushed a commit that referenced this issue Dec 7, 2022
@emilwihlander @emil-wihlander-zynka @mp911de
Implement support for interval units.
96c9d3d 
[#566][resolves #565]

Co-authored-by: Emil Wihlander <[email protected]>
@mp911de mp911de linked a pull request Dec 7, 2022 that will close this issue
Implement support for interval units. #566
Merged
4 tasks
@mp911de mp911de added this to the 1.0.1.RELEASE milestone Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: ideal-for-contribution An issue that a contributor can help us with type: bug A general bug
Projects
None yet
Milestone
1.0.1.RELEASE
Development

Successfully merging a pull request may close this issue.

Implement support for interval units. emilwihlander/r2dbc-postgresql
2 participants
@mp911de @emilwihlander