Skip to content

Allow disable name field in signup form #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2015
Merged

Allow disable name field in signup form #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ParseUI-Login/src/main/java/com/parse/ui/ParseLoginBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,18 @@ public ParseLoginBuilder setParseSignupSubmitButtonText(int id) {
return setParseSignupSubmitButtonText(maybeGetString(id));
}

/**
* Whether to show the name field in the signup form. Default is true.
*
* @param enabled
* Whether to show the name field in the signup form.
* @return The caller instance to allow chaining.
*/
public ParseLoginBuilder setParseSignupNameFieldEnabled(boolean enabled) {
config.setParseSignupNameFieldEnabled(enabled);
return this;
}

/**
* Whether to show the Facebook login option on the login screen. Default is
* false.
Expand Down
20 changes: 20 additions & 0 deletions ParseUI-Login/src/main/java/com/parse/ui/ParseLoginConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ public class ParseLoginConfig {
public static final String PARSE_LOGIN_EMAIL_AS_USERNAME = "com.parse.ui.ParseLoginActivity.PARSE_LOGIN_EMAIL_AS_USERNAME";
public static final String PARSE_SIGNUP_MIN_PASSWORD_LENGTH = "com.parse.ui.ParseLoginActivity.PARSE_SIGNUP_MIN_PASSWORD_LENGTH";
public static final String PARSE_SIGNUP_SUBMIT_BUTTON_TEXT = "com.parse.ui.ParseLoginActivity.PARSE_SIGNUP_SUBMIT_BUTTON_TEXT";
public static final String PARSE_SIGNUP_NAME_FIELD_ENABLED = "com.parse.ui.ParseLoginActivity.PARSE_SIGNUP_NAME_FIELD_ENABLED";
public static final String FACEBOOK_LOGIN_ENABLED = "com.parse.ui.ParseLoginActivity.FACEBOOK_LOGIN_ENABLED";
public static final String FACEBOOK_LOGIN_BUTTON_TEXT = "com.parse.ui.ParseLoginActivity.FACEBOOK_LOGIN_BUTTON_TEXT";
public static final String FACEBOOK_LOGIN_PERMISSIONS = "com.parse.ui.ParseLoginActivity.FACEBOOK_LOGIN_PERMISSIONS";
Expand All @@ -70,6 +71,7 @@ public class ParseLoginConfig {
private Boolean parseLoginEmailAsUsername;
private Integer parseSignupMinPasswordLength;
private CharSequence parseSignupSubmitButtonText;
private Boolean parseSignupNameFieldEnabled;

private Boolean facebookLoginEnabled;
private CharSequence facebookLoginButtonText;
Expand Down Expand Up @@ -160,6 +162,18 @@ public void setParseSignupSubmitButtonText(
this.parseSignupSubmitButtonText = parseSignupSubmitButtonText;
}

public Boolean isParseSignupNameFieldEnabled() {
if (parseSignupNameFieldEnabled != null) {
return parseSignupNameFieldEnabled;
} else {
return true;
}
}

public void setParseSignupNameFieldEnabled(Boolean parseSignupNameFieldEnabled) {
this.parseSignupNameFieldEnabled = parseSignupNameFieldEnabled;
}

public boolean isFacebookLoginEnabled() {
if (facebookLoginEnabled != null) {
return facebookLoginEnabled;
Expand Down Expand Up @@ -267,6 +281,9 @@ public Bundle toBundle() {
bundle.putCharSequence(PARSE_SIGNUP_SUBMIT_BUTTON_TEXT,
parseSignupSubmitButtonText);
}
if (parseSignupNameFieldEnabled != null) {
bundle.putBoolean(PARSE_SIGNUP_NAME_FIELD_ENABLED, parseSignupNameFieldEnabled);
}

if (facebookLoginEnabled != null) {
bundle.putBoolean(FACEBOOK_LOGIN_ENABLED, facebookLoginEnabled);
Expand Down Expand Up @@ -336,6 +353,9 @@ public static ParseLoginConfig fromBundle(Bundle bundle, Context context) {
if (keys.contains(PARSE_SIGNUP_SUBMIT_BUTTON_TEXT)) {
config.setParseSignupSubmitButtonText(bundle.getCharSequence(PARSE_SIGNUP_SUBMIT_BUTTON_TEXT));
}
if (keys.contains(PARSE_SIGNUP_NAME_FIELD_ENABLED)) {
config.setParseSignupNameFieldEnabled(bundle.getBoolean(PARSE_SIGNUP_NAME_FIELD_ENABLED));
}

if (keys.contains(FACEBOOK_LOGIN_ENABLED)) {
config.setFacebookLoginEnabled(bundle.getBoolean(FACEBOOK_LOGIN_ENABLED));
Expand Down
11 changes: 7 additions & 4 deletions ParseUI-Login/src/main/java/com/parse/ui/ParseSignupFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@ public View onCreateView(LayoutInflater inflater, ViewGroup parent,
minPasswordLength = config.getParseSignupMinPasswordLength();
}

String username = (String) args.getString(USERNAME);
String password = (String) args.getString(PASSWORD);
String username = args.getString(USERNAME);
String password = args.getString(PASSWORD);

View v = inflater.inflate(R.layout.com_parse_ui_parse_signup_fragment,
parent, false);
Expand All @@ -91,6 +91,9 @@ public View onCreateView(LayoutInflater inflater, ViewGroup parent,
.findViewById(R.id.signup_confirm_password_input);
emailField = (EditText) v.findViewById(R.id.signup_email_input);
nameField = (EditText) v.findViewById(R.id.signup_name_input);
if (!config.isParseSignupNameFieldEnabled()) {
nameField.setVisibility(View.INVISIBLE);
}
createAccountButton = (Button) v.findViewById(R.id.create_account);

usernameField.setText(username);
Expand Down Expand Up @@ -172,7 +175,7 @@ public void onClick(View v) {
confirmPasswordField.requestFocus();
} else if (email != null && email.length() == 0) {
showToast(R.string.com_parse_ui_no_email_toast);
} else if (name != null && name.length() == 0) {
} else if (name != null && name.length() == 0 && config.isParseSignupNameFieldEnabled()) {
showToast(R.string.com_parse_ui_no_name_toast);
} else {
ParseUser user = new ParseUser();
Expand All @@ -183,7 +186,7 @@ public void onClick(View v) {
user.setEmail(email);

// Set additional custom fields only if the user filled it out
if (name.length() != 0) {
if (name.length() != 0 && config.isParseSignupNameFieldEnabled()) {
user.put(USER_OBJECT_NAME_FIELD, name);
}

Expand Down