Fix matching of jsClassProperty without an initial value #1202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the following code
The
baz
is properly matched as ajsClassProperty
butbar is
jsClassBody. The regex for
jsClassPropertywas requiring the
=that followed the property name. The changes allow value less properties by allowing either
;or
=` to follow the name.jsClassPropertyComputed
was not affected since that is matched by using the delimiters[]
andthat works regardless of an initial value. But I noticed that for properties that have no semicolons
then the matching does not work for property values as well. I don't know if the recent spec
actually requires semicolons, so I didn't add it yet. But I would add it if class properties without
semicolons are still allowed.