Skip to content

TST: adding sdist and install tests to the 2.6 regression - closes #9878 #9922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

ajamian
Copy link
Contributor

@ajamian ajamian commented Apr 17, 2015

closes #9878

This PR adds a test for packaging and installing pandas from a tarball, inside of the 2.6 regression.

After regular nosetests complete, cython is removed from the venv, pandas is packaged with cdist command, and the package is installed via pip. Limited nosetests run once installed.

The travis log output is a little messy with the pip command output; ideally I wanted to 'fold'/collapse the output unless there was a failure but I don't think you can do that from within the 'script' portion of the regression, only the before and after scripts, see:
http://blog.travis-ci.com/2013-05-22-improving-build-visibility-log-folds/
If there is a way to do this maybe we can add it later, or move where this INSTALL_TEST is happening to a before or after script.

@jreback jreback added Testing pandas testing functions or related to the test suite Build Library building on various platforms labels Apr 17, 2015
@jreback jreback added this to the 0.16.1 milestone Apr 17, 2015
@jreback
Copy link
Contributor

jreback commented Apr 17, 2015

I think that you can add another entry after the script (and put your change in), maybe something like. install_test.sh which will 'fold' it (I think if you run separate scripts it folds that output

This is in .travis.yml

script:
  - echo "script"
  - ci/script.sh
# nothing here, or failed tests won't fail travis

@ajamian
Copy link
Contributor Author

ajamian commented Apr 18, 2015

@jrebeck I gave this a try; it looks like log output will only fold if it is outside the 'script' section of the travis job (here is the log output a separate install_test.sh script: https://travis-ci.org/ajamian/pandas/jobs/58972085)

Is it ok if we put the install_test in say the after_scripts section? I think this would give the folding.

@jreback
Copy link
Contributor

jreback commented Apr 18, 2015

yep that's ok too

@ajamian
Copy link
Contributor Author

ajamian commented Apr 19, 2015

@jreback looks like folding works for stuff in the after_script section of travis - i put it before everything else in that section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test for sdist and pandas import
2 participants