-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Use 'python-dateutil' instead of 'dateutil' for requirement files #9898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use 'python-dateutil' instead of 'dateutil' for requirement files #9898
Conversation
these are tailored to conda installs, so this will not work |
This will work, because |
@chrish42 pls ping when this is green (I restarted the jobs). |
hmm, sees |
Works now with conda:
|
hmm, can you rebase on master and push again? |
Rebased, but two of the builds are still failing. |
@@ -1,4 +1,4 @@ | |||
dateutil=2.1 | |||
python-dateutil=2.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
travis fails because this doesn't exist on conda
@chrish42 so the older versions of dateutil fail here because they don't exist on conda. They can be built and posted to the |
…cept for the old versions), as the former also is known to the 'pip install' command.
Change for versions where python-dateutils is not available undone. Also rebased. |
Use 'python-dateutil' instead of 'dateutil' for requirement files
@chrish42 thanks! |
The former also is known to the 'pip install' command, and still works with conda install. Making requirements files compatible with 'pip install' is more relevant now that packages like numpy have a (binary) wheel available.