Skip to content

Use 'python-dateutil' instead of 'dateutil' for requirement files #9898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2015
Merged

Use 'python-dateutil' instead of 'dateutil' for requirement files #9898

merged 1 commit into from
Jun 9, 2015

Conversation

chrish42
Copy link
Contributor

The former also is known to the 'pip install' command, and still works with conda install. Making requirements files compatible with 'pip install' is more relevant now that packages like numpy have a (binary) wheel available.

@jreback
Copy link
Contributor

jreback commented Apr 14, 2015

these are tailored to conda installs, so this will not work

@cpcloud
Copy link
Member

cpcloud commented Apr 14, 2015

This will work, because conda accepts python-dateutil.

@cpcloud cpcloud added this to the 0.16.1 milestone Apr 14, 2015
@cpcloud cpcloud added Enhancement Build Library building on various platforms CI Continuous Integration labels Apr 14, 2015
@jreback
Copy link
Contributor

jreback commented Apr 28, 2015

@chrish42 pls ping when this is green (I restarted the jobs).

@jreback
Copy link
Contributor

jreback commented May 4, 2015

hmm, sees python-dateutil not defined in the default conda channel....?

@jreback jreback modified the milestones: 0.17.0, 0.16.1 May 4, 2015
@chrish42
Copy link
Contributor Author

Works now with conda:

$ conda create -n test python-dateutil
Fetching package metadata: ....
Solving package specifications: .
Package plan for installation in environment /Users/chrish/anaconda/envs/test:

The following NEW packages will be INSTALLED:

    openssl:         1.0.1k-1
    pip:             6.1.1-py27_0
    python:          2.7.9-1
    python-dateutil: 2.4.2-py27_0
    readline:        6.2-2
    setuptools:      15.2-py27_0
    six:             1.9.0-py27_0
    sqlite:          3.8.4.1-1
    tk:              8.5.18-0
    zlib:            1.2.8-0

Proceed ([y]/n)?

@jreback
Copy link
Contributor

jreback commented May 19, 2015

hmm, can you rebase on master and push again?

@chrish42
Copy link
Contributor Author

Rebased, but two of the builds are still failing.

@@ -1,4 +1,4 @@
dateutil=2.1
python-dateutil=2.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

travis fails because this doesn't exist on conda

@jreback
Copy link
Contributor

jreback commented May 20, 2015

@chrish42 so the older versions of dateutil fail here because they don't exist on conda.

They can be built and posted to the pandas binstar channel. But would need to do for all arches. Alternative is to not change those for those builds in the ci file.

…cept for the old versions),

as the former also is known to the 'pip install' command.
@chrish42
Copy link
Contributor Author

chrish42 commented Jun 6, 2015

Change for versions where python-dateutils is not available undone. Also rebased.

@jreback jreback modified the milestones: 0.16.2, 0.17.0 Jun 9, 2015
jreback added a commit that referenced this pull request Jun 9, 2015
Use 'python-dateutil' instead of 'dateutil' for requirement files
@jreback jreback merged commit 39da6da into pandas-dev:master Jun 9, 2015
@jreback
Copy link
Contributor

jreback commented Jun 9, 2015

@chrish42 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms CI Continuous Integration Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants