ENH: Raise error writing excel file with a MultiIndexed DataFrame #9794 #9889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -52,6 +52,8 @@ Enhancements | |||
|
|
|||
| - Allow timedelta string conversion when leading zero is missing from time definition, ie `0:00:00` vs `00:00:00`. (:issue:`9570`) | |||
|
|
|||
| - Trying to write an excel file now raises error if the DataFrame has a MultiIndex instead of writing a broken Excel file. (:issue:`9794`) | |||
There was a problem hiding this comment.
raises a NotImplementedError
|
can you add a tests that validates this. otherwise looks good. |
jreback
added
Error Reporting
|
Actually I just saw there is a some tests that test writing excel with multiindex https://github.com/pydata/pandas/blob/master/pandas/io/tests/test_excel.py#L895 Referencing: ill figure out what the difference is |
hsperr
force-pushed
the
excel_multiindex
branch
from
bbe6539 to
fed64b3
Compare
|
I added two tests that make sure writing MultiIndex index works and MultiIndex columns raise. |
hsperr
force-pushed
the
excel_multiindex
branch
from
fed64b3 to
3d515dd
Compare
hsperr
force-pushed
the
excel_multiindex
branch
from
3d515dd to
a97113c
Compare
|
fixed the backticks in whats new and modified the test for multicolumn/index writing to assert fails only on multicolumn writes |
jreback
added a commit
that referenced
this pull request
Apr 17, 2015
ENH: Raise error writing excel file with a MultiIndexed DataFrame #9794
|
@hsperr thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise a NotImplementedError until fixed.
closes #9794