Period accepts datetime64 value #9869
Closed
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -226,7 +226,9 @@ def test_period_constructor(self): | |||
|
|
|||
| i1 = Period(date(2007, 1, 1), freq='M') | |||
| i2 = Period(datetime(2007, 1, 1), freq='M') | |||
| i3 = Period(np.datetime64('2007-01-01'), freq='M') | |||
There was a problem hiding this comment.
can you add a couple of more tests that have different numpy units,
e.g.
In [3]: np.datetime64('2007-01-01 00:00:00',dtype='M8[s]').dtype
Out[3]: dtype('<M8[s]')
|
pls add a release note as wel, looks good otherwise. |
|
+1, will be awhile for travis, lots of PRs today :) |
|
can you squash into a single commit. pls ping when done. |
Added support for `datetime64` value for Period. Fixes pandas-dev#9054.
|
@jreback : squashed. |
|
closing in favor of #9896 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for
datetime64value for Period. Fixes #9054.