BUG: memory access bug in read_csv causing segfault #9846
Merged
+69
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
force-pushed
the
read-csv-segfault
branch
2 times, most recently
from
abfb27c to
c0d4b84
Compare
|
can you add a release note, otherwise lgtm |
behzadnouri
force-pushed
the
read-csv-segfault
branch
from
c0d4b84 to
a8b99ba
Compare
|
@jreback added the release note |
jreback
added a commit
that referenced
this pull request
Apr 12, 2015
BUG: memory access bug in read_csv causing segfault
|
thank you sir! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5664
the added test covers the original issue, though I cannot reproduce that on master; the one mentioned in the comments still segfaults on master (if repeated few times) and is fixed by this pr.