ERR: raise when index_col=True is passed #9835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -905,7 +905,7 @@ def _make_index(self, data, alldata, columns, indexnamerow=False): | |||
|
|
|||
| def _get_simple_index(self, data, columns): | |||
| def ix(col): | |||
| if not isinstance(col, compat.string_types): | |||
| if not (isinstance(col, compat.string_types) or col is True): | |||
There was a problem hiding this comment.
move this to TextFileReader in the _clean_options (or __init__)
jreback
changed the title
|
I moved it to TextFileReader in the |
|
ok, pls squash, then looks good to go. ping me when green. |
BUG: pandas-dev#9798 `index_col` shouldn't accept the value `True` move the check to ``TextFileReader`` ``clean_options``
|
hi @jreback , I've squashed the commits, and it's green now. could u take a look on it? |
jreback
added a commit
that referenced
this pull request
Apr 9, 2015
ERR: raise when index_col=True is passed
|
@bottleimp thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9798
Add a check to see whether the
index_colisTrue.