-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: regenerate CONTRIBUTING.md #9797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
xref GH9754, GH9796
Created with: pandoc doc/source/contributing.rst -t markdown > CONTRIBUTING.md xref GH9796
lgtm |
What I had in mind for this actually just having a link to the pandas documentation in contributing.md. The whole point of this was to have all the documentation in one place so they are never disconnected. |
GitHub seems to want to have a CONTRUBUTING.md file to show to the user. |
I was thinking something like the below on the page: Thank you for contributing to pandas. Please see our guidelines here |
I also think having things not duplicated would be better. But I think it should be possible to 'include' the version in the docs into the CONTRIBUTING one with Otherwise I would also go for a link to the developers docs, but maybe with a kind of shorter 'summary' |
Unfortunately a CONTRIBUTING.rst file doesn't work. So that rules out using an include. I'm not opposed to making this file just a link, but it also seems safe enough to just generate it automatically with pandoc.... that seems like it will be straightforward enough to keep up to date. |
I agree let's just out the pandoc command in the wiki somewhere |
ok! |
Just put the instructions in the wiki, see the bottom here: https://github.com/pydata/pandas/wiki |
To answer your question, the heavy nesting was intentional (and I still think we should find a way to do it in CONTRIBUTING). Everything was setup to be sequential so after you checkout, then you either work on the docs or the code and then you commit. So I think both the contributing to docs/code should be on same level as those two other things (and the rest of the workflow). Maybe what we should be doing here is to pull out the |
Oh, OK :). In that case, my mistake -- please feel free to revert. I'm guessing you might have mixed up subsection styles (e.g., |
This is an alternative to #9796.
I simply did a couple of changes to the restructuredtext source so it generates cleaner markdown. The main thing was making the categories not quite so nested. (Was that heavy nesting intentional?) I think pandoc was running out of header styles or something like that.
cc @rockg @jreback @jorisvandenbossche