Skip to content

DOC: regenerate CONTRIBUTING.md #9797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2015

Conversation

shoyer
Copy link
Member

@shoyer shoyer commented Apr 3, 2015

This is an alternative to #9796.

I simply did a couple of changes to the restructuredtext source so it generates cleaner markdown. The main thing was making the categories not quite so nested. (Was that heavy nesting intentional?) I think pandoc was running out of header styles or something like that.

cc @rockg @jreback @jorisvandenbossche

shoyer added 2 commits April 2, 2015 21:48
Created with:

    pandoc doc/source/contributing.rst -t markdown > CONTRIBUTING.md

xref GH9796
@shoyer shoyer added the Docs label Apr 3, 2015
@shoyer shoyer added this to the 0.16.1 milestone Apr 3, 2015
@jreback
Copy link
Contributor

jreback commented Apr 3, 2015

lgtm

@rockg
Copy link
Contributor

rockg commented Apr 3, 2015

What I had in mind for this actually just having a link to the pandas documentation in contributing.md. The whole point of this was to have all the documentation in one place so they are never disconnected.

@jreback
Copy link
Contributor

jreback commented Apr 3, 2015

GitHub seems to want to have a CONTRUBUTING.md file to show to the user.
but I think we all agree it's better in the docs
not sure how we can have only a link (well we could but it's not as nice as a rendered markdown) in the CONTRIBUTING.md file

@rockg
Copy link
Contributor

rockg commented Apr 3, 2015

I was thinking something like the below on the page:

Thank you for contributing to pandas. Please see our guidelines here

@jorisvandenbossche
Copy link
Member

I also think having things not duplicated would be better. But I think it should be possible to 'include' the version in the docs into the CONTRIBUTING one with ..inlcude::. Or does the CONTRIBUTING has to be markdown?

Otherwise I would also go for a link to the developers docs, but maybe with a kind of shorter 'summary'

@shoyer shoyer merged commit 8959ce2 into pandas-dev:master Apr 3, 2015
@shoyer
Copy link
Member Author

shoyer commented Apr 3, 2015

Unfortunately a CONTRIBUTING.rst file doesn't work. So that rules out using an include.

I'm not opposed to making this file just a link, but it also seems safe enough to just generate it automatically with pandoc.... that seems like it will be straightforward enough to keep up to date.

@jreback
Copy link
Contributor

jreback commented Apr 3, 2015

I agree

let's just out the pandoc command in the wiki somewhere

@jorisvandenbossche
Copy link
Member

ok!

@shoyer
Copy link
Member Author

shoyer commented Apr 3, 2015

Just put the instructions in the wiki, see the bottom here: https://github.com/pydata/pandas/wiki

@rockg
Copy link
Contributor

rockg commented Apr 3, 2015

To answer your question, the heavy nesting was intentional (and I still think we should find a way to do it in CONTRIBUTING). Everything was setup to be sequential so after you checkout, then you either work on the docs or the code and then you commit. So I think both the contributing to docs/code should be on same level as those two other things (and the rest of the workflow).

Maybe what we should be doing here is to pull out the Contributing to the Code Base into a separate .rst file and then only convert that subfile into contributing.md. I think that is really the relevant section for ensuring a pull request is following the project's guidelines. I can play around with that.

@shoyer
Copy link
Member Author

shoyer commented Apr 3, 2015

Oh, OK :). In that case, my mistake -- please feel free to revert. I'm guessing you might have mixed up subsection styles (e.g., ~~~~~~~ vs """""""""") -- it looked like almost everything converted properly except for one section title.

@shoyer shoyer deleted the contributing-reformat branch April 3, 2015 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants