BUG: datetime/timedelta Series quantile() call #9694
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6837,6 +6837,10 @@ def test_repeat(self): | |||
| def test_unique_data_ownership(self): | |||
| # it works! #1807 | |||
| Series(Series(["a", "c", "b"]).unique()).sort() | |||
|
|
|||
| def test_datetime_timedelta_quantiles(self): | |||
| self.assertTrue(pd.isnull(Series([],dtype='M8[ns]').quantile(.5))) | |||
There was a problem hiding this comment.
add the issue as a comment here
|
pls add a release note for what's new/0.16.1 (bug fix section) |
| @@ -31,3 +31,5 @@ Performance Improvements | |||
|
|
|||
| Bug Fixes | |||
| ~~~~~~~~~ | |||
|
|
|||
| - Bug in ``Series.quantile`` on Series of type ``Datetime`` or ``Timedelta`` (:issue:`9675`) | |||
There was a problem hiding this comment.
mention that this is with an empty Series
|
pls squash to a single commit |
Changes to be committed: modified: pandas/core/series.py modified: pandas/tests/test_series.py Fixes global reference to iNaT (should be tslib.iNaT) in series._maybe_box. Adds test `test_datetime_timedelta_quantiles` to check for proper return value in test_series.py. Issue #9675
|
merged via a477202 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to be committed:
modified: pandas/core/series.py
modified: pandas/tests/test_series.py
Fixes global reference to iNaT (should be tslib.iNaT) in series._maybe_box.
Adds test
test_datetime_timedelta_quantilesto check for proper return valuein test_series.py.
Issue #9675