Fixes groupby.apply() error when no returns #9684 #9685
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, don't quite follow. Would you mind elaborating? |
| @@ -2808,7 +2808,12 @@ def _wrap_applied_output(self, keys, values, not_indexed_same=False): | |||
|
|
|||
| # make Nones an empty object | |||
| if com._count_not_none(*values) != len(values): | |||
| v = next(v for v in values if v is not None) | |||
| try: | |||
There was a problem hiding this comment.
v = [ v for v in values if v is not None ]
if not v:
return DataFrame()
|
OK -- I'd then need to extract the first item from the list below that. That still preferable? |
|
@nickeubank hmm, maybe leave it the original (and put in a try except for StopIteration like you did). |
|
whats new is now available for 0.16.1 5ebf521 |
|
pls add a test and a mention in v0.16.1 whatsnew. |
| @@ -55,7 +55,7 @@ Bug Fixes | |||
|
|
|||
|
|
|||
| - Bug in ``transform`` causing length mismatch when null entries were present and a fast aggregator was being used (:issue:`9697`) | |||
|
|
|||
| - Fixed bug in groupby.apply() that would cause error if no values returned. (:issue:`9685`) | |||
There was a problem hiding this comment.
use backticks around groupby.apply and reprase as bit: "would raise if the return value of the user passed function was None "
|
merged via 990972b thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue: #9684
Returns empty object even if all entries are missing.