Allow clip{,_lower,_upper} to use array-like thresholds (GH 6966) #9647
Conversation
|
Sorry, first time contributing. My local testing wasn't getting to test_frame and test_series like I thought it was. This second commit should fix the problems. |
| @@ -2801,14 +2801,16 @@ def notnull(self): | |||
| """ | |||
There was a problem hiding this comment.
pls make sure that you have core.filemode=False in git
e.g. git config global --list (then turn it off). you generally don't change file modes (as they are set so that nose works correctly)
|
pls add a release note in whatnew (0.16.1), which will be available after we release 0.16.0 (prob this weekend) |
|
whats new is now available for 0.16.1 5ebf521 |
|
I'm pretty sure the test failure is caused by a bug which is independent of my changes: pandas/io/data.py lines 174-182 should be indented and part of the else clause. |
| lower : float or array_like, default None | ||
| upper : float or array_like, default None | ||
| axis : int or string axis name, optional | ||
| Align object with lower and upper along the given axis. | ||
|
|
There was a problem hiding this comment.
can you add a doc-string example here (have a look at a function, say DataFrame.select_dtypes for how to format this in the dco-string)
| @@ -19,6 +19,7 @@ Enhancements | |||
|
|
|||
There was a problem hiding this comment.
you changed the mode of this file, can you revert pls.
|
@evanpw ok, if you can fix the file modes, looks good otherwise |
|
Mode is fixed, rebased, squashed, and tests are green. |
Allow clip{,_lower,_upper} to use array-like thresholds (GH 6966)
|
ty sir! |
closes #6966