support constructing Panel or Panel4D with scalar data, fixes #8285 #9640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -888,6 +888,21 @@ def test_constructor(self): | |||
| wp = Panel(vals, copy=True) | |||
| self.assertIsNot(wp.values, vals) | |||
|
|
|||
| # test when scalar data is used to construct a Panel | |||
| # if dtype is not passed, it should be inferred | |||
| value_and_dtype = [(1, int), (3.14, float), ('foo', np.object_)] | |||
|
ok, pls add a release note (this can go in 0.16.0) |
mortada
force-pushed
the
panel_init_scalar
branch
from
eae8083 to
09be167
Compare
| dtype, data = _infer_dtype_from_scalar(data) | ||
| values = np.empty([len(x) for x in passed_axes], dtype=dtype) | ||
| values.fill(data) | ||
| mgr = self._init_matrix(values, passed_axes, dtype=dtype, copy=copy) |
There was a problem hiding this comment.
I think you need to make copy= False before you init the matrix (so it doesn't copy it again). Copy is irrelevant with a scalar anyhow.
mortada
force-pushed
the
panel_init_scalar
branch
from
09be167 to
cc8bf97
Compare
|
@jreback thanks it's fixed now |
jreback
added a commit
that referenced
this pull request
Mar 14, 2015
support constructing Panel or Panel4D with scalar data, fixes #8285
|
@mortada thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should fix #8285