Test added and patch to fix python-version-dependent issues when len ro... #9583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -54,7 +54,7 @@ def get_indexers(levels): | |||
| def _get_label_to_i_dict(labels, sort_labels=False): | |||
| """ Return OrderedDict of unique labels to number. | |||
| Optionally sort by label. """ | |||
| labels = Index(map(tuple, labels)).unique().tolist() # squish | |||
| labels = Index(list(map(tuple, labels))).unique().tolist() # squish | |||
| if sort_labels: | |||
There was a problem hiding this comment.
use lmap, which imports from pandas.compat (and handles the 2/3 differences)
… row/col_levels is 1.
|
Put the lmap in. Will check the docs again once this is merged. |
jreback
added a commit
that referenced
this pull request
Mar 5, 2015
Test added and patch to fix python-version-dependent issues when len ro...
|
@cottrell thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...w/col_levels is 1.
The docs for sparse to_coo methods failed to build. There was some case (row_levels len 1) that failed in python 2.7 only that I failed to test (and I have been building docs in python 3). Have added test and patched. Also needed to expand the interator (list(map(... ) in the "# squish" line as there was some tupleizing differences between python 3 and 2.
Perhaps there is a better way to avoid these issues? Waiting for Travis.