Skip to content

CLN: import packers/gbq/html only on-demand (GH9482) #9487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2015

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Feb 13, 2015

closes #9482
so a 30% reduction in import time

[jreback-~/pandas] time python -c 'import pandas'
0.788u 0.120s 0:00.91 98.9%     0+0k 0+7io 0pf+0w
[jreback-~/pandas] time python -c 'import pandas'
0.782u 0.115s 0:00.91 97.8%     0+0k 0+0io 0pf+0w
[jreback-~/pandas] time python -c 'import pandas'
0.790u 0.121s 0:00.91 100.0%    0+0k 0+0io 0pf+0w
[jreback-~/pandas] time python -c 'import pandas'
0.270u 0.091s 0:00.37 97.2%     0+0k 10+20io 0pf+0w
[jreback-~/pandas] time python -c 'import pandas'
0.262u 0.087s 0:00.35 97.1%     0+0k 0+0io 0pf+0w
[jreback-~/pandas] time python -c 'import pandas'
0.264u 0.088s 0:00.36 94.4%     0+0k 0+0io 0pf+0w

@jreback jreback added the Compat pandas objects compatability with Numpy or Python functions label Feb 13, 2015
@jreback jreback added this to the 0.16.0 milestone Feb 13, 2015
@jreback
Copy link
Contributor Author

jreback commented Feb 13, 2015

This seems to work (meaning that it doesn't import these except on-demand), can people give this a try

@TomAugspurger @shoyer @jorisvandenbossche @cpcloud
cc @rockg

from the related issues
cc @thomasj02
cc @mpenning
cc @ndc33
cc @steve3141

@jreback
Copy link
Contributor Author

jreback commented Feb 23, 2015

any comments on this?

@jorisvandenbossche
Copy link
Member

Looks good to me! (gave it a quick test and glance over the code)

jreback added a commit that referenced this pull request Feb 24, 2015
CLN: import packers/gbq/html only on-demand (GH9482)
@jreback jreback merged commit 6deef72 into pandas-dev:master Feb 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLN: make sure that we don't have extraneous imports
2 participants