Skip to content

TST: Remove assertEquals #9465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2015
Merged

TST: Remove assertEquals #9465

merged 1 commit into from
Feb 16, 2015

Conversation

sinhrks
Copy link
Member

@sinhrks sinhrks commented Feb 11, 2015

Same as #7165. I've also added some of these tests :(

One idea to prevent this is to override ``tm.TestCase.assertEquals` to raise more explicit warning or exception.

@jreback
Copy link
Contributor

jreback commented Feb 11, 2015

@sinhrks while don't we just make assertEquals == assertEqual (with a warning) though

@jreback jreback added the Testing pandas testing functions or related to the test suite label Feb 11, 2015
@jreback jreback added this to the 0.16.0 milestone Feb 11, 2015
@sinhrks
Copy link
Member Author

sinhrks commented Feb 15, 2015

Made suggested changes based on the unittest doc. Used deprecate decorator as a function because it can't used in the class definition.

Followings are not changed.

  • assertRegexpMatches: Inroduced in python 3.1 and not used in the script. No need to be cared.
  • assertRaisesRegexp: Introduced in python 3.1, but uses original implementation in util.testing. Thus untouched.

jreback added a commit that referenced this pull request Feb 16, 2015
@jreback jreback merged commit acd2422 into pandas-dev:master Feb 16, 2015
@jreback
Copy link
Contributor

jreback commented Feb 16, 2015

thanks you sir!

@sinhrks sinhrks deleted the assertequals branch March 31, 2015 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants