BUG: setup.py does not allow equal filenames in *different* directories

[blbradley]

Is it possible to write tests for setup.py?

Setup

touch pandas/period.pyx

and put this in your setup.py's ext_data:

    period=dict(pyxfile='period'),

Before PR

python setup.py build_ext --inplace
rm -rf pandas/period.c
python setup.py build_ext --inplace
python setup.py clean 
ls -l pandas/period.c
# -rw-rw-r-- 1 brandon brandon 48253 Feb  4 15:27 pandas/period.c

period.c still exists after cleaning.

After PR

python setup.py build_ext --inplace
rm -rf pandas/period.c
python setup.py build_ext --inplace
python setup.py clean
ls -l pandas/period.c   
# ls: cannot access pandas/period.c: No such file or directory

[jreback]

can't remove ujson from this as these are part of the src/ujson/lib dir.

maybe directly specify ALL of the *.c files by dir and filename (or just dir) for the exclusions

[blbradley]

f is this context is the filename (only). So the ujson conditional doesn't do anything since those filenames are already part of the list.

I thought about that but didn't want to break the way it worked before. So you are saying that all excluded files should be referred to by their project root relative path? e.g. src/ujson/lib/ultrajsondec.c. I believe directories should be allowed for exclusion also.

Edited: directory example

[blbradley]

The ujson conditional also does nothing because none of the filenames in src/ujson/lib have ujson in them.

[jreback]

you could write tests for setup.py in that you could assert existance of certain files known to be there. It would guard against a file being removed that is known (e.g. period.c which should be there), but, if a new file were added then it couldn't assert for that (e.g. say you added a module which add foo.c), so would be a bit tricky to keep the tests in sync.

So kind of +/- 0 on this.

[blbradley]

@jreback gotcha. thanks for the input on testing.

[jreback]

this is much more explicit which is good

[jreback]

@blbradley thanks for this

[blbradley]

@jreback That was the easy one. 😏