-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TST/DOC: Add procedure for TestPickle #9401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
yep. Is there any way to have setup automatically pick up all of the directories under a tree in package_data ? |
@jreback Yeah it's better. Modified both |
self.read_pickles('0.14.0') | ||
n += 1 | ||
assert n > 0, 'Pickle files are not tested' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rather than making these in one test, can you have a routine which create tests from the legacy_pickle dir (like you are doing now), but makes them separate tests (so need to do this at import time). That way you can see them running indepedently (and if they fail they would fail independetly)
af85543
to
ac487ad
Compare
OK. I understand that to make When execute the test, we will see:
|
@@ -18,7 +18,17 @@ | |||
from pandas.util.misc import is_little_endian | |||
import pandas | |||
|
|||
class TestPickle(tm.TestCase): | |||
class TestPickle(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put a comment why we are not sub-classing TestCase here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
@sinhrks ok a possible 'soln' to this is to make make all of the methods in tm.TestCase (currently) into a MixIn (and include it there, so nothing changes). And then you can use the MixIn here. |
TST/DOC: Add procedure for TestPickle
thanks for this! |
Added procedure to
TestPickle
. Based on #9291, I think updatingsetup.py
is likely to be ommitted.