ENH: StringMethods now supports ljust and rjust #9352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
sinhrks
force-pushed
the
string_fillchar
branch
from
34e445f to
6a9f4fb
Compare
|
this needs to go after #9322 (and might need a rebase after that) as the docs are changing a bit) |
|
Just merged #9322, so this needs a rebase now. |
| @@ -576,7 +580,7 @@ def str_findall(arr, pat, flags=0): | |||
| return _na_map(regex.findall, arr) | |||
|
|
|||
|
|
|||
| def str_pad(arr, width, side='left'): | |||
| def str_pad(arr, width, side='left', fillchar=' '): | |||
There was a problem hiding this comment.
Can you add here an explanation of the new kwarg fillchar as well?
sinhrks
force-pushed
the
string_fillchar
branch
from
6a9f4fb to
0b679b4
Compare
jreback
added a commit
that referenced
this pull request
Jan 29, 2015
ENH: StringMethods now supports ljust and rjust
|
thanks @sinhrks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derived from #9111.
StringMethods.ljustandStringMethods.rjustto be consistent with standardstr.fillcharoption toStringMethods.padandStringMethods.centerto be consistent with standardstr.center