Fix gbq client to only return results when jobCompleted is True. #9348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When polling for a long-running gbq job to determine if it is complete, we should only return results once
query_results['jobCompleted']
isTrue
, not just when thejobCompleted
key exists. Otherwise, the gbq client thinks results exist and it will start attempting to parse the results, leading to a weird KeyError:This simple patch accounts for the case where
query_results['jobCompleted']
isFalse
.