FIX: Add endianness missing flag when reading data #9264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if self.byteorder != self._native_byteorder: | ||
| print(data.dtype) | ||
| data = data.byteswap().newbyteorder() | ||
| print(data.dtype) |
There was a problem hiding this comment.
prints left from debugging or really intended for some reason?
There was a problem hiding this comment.
Should not be there...
bashtage
force-pushed
the
stata-fix-bigendian
branch
from
f074b75 to
8fbe379
Compare
|
@yarikoptic @jreback I think this one is ready. |
jreback
added
Testing
|
@yarikoptic ok on these platforms? |
|
@bashtage IIRC the tests are disabled on non-small so is this actually tested? |
Added endianess flat to data type to allow data to be read cross platforms closes pandas-dev#8688
|
All of the tests were re-enabled for big-endian a few releases ago. There are only three tests that are skipped on any platform: https://github.com/pydata/pandas/blob/master/pandas/io/tests/test_stata.py#L256 I would like to kill these in a different PR since they rely on proprietary data and so will never be re-enabled. |
bashtage
force-pushed
the
stata-fix-bigendian
branch
from
8fbe379 to
3f46c7a
Compare
|
ok, ping on green |
|
@jreback It is ready. |
jreback
added a commit
that referenced
this pull request
Jan 16, 2015
FIX: Add endianness missing flag when reading data
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added endianess flat to data type to allow data to be read cross platforms
closes #8688