ENH: add Timestamp.to_datetime64 #9255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm, its called |
|
|
|
hmm that could be useful |
|
Any comments on this PR? (Tests are green) |
| @@ -136,6 +136,20 @@ def test_constructor_with_stringoffset(self): | |||
| self.assertEqual(repr(result), expected_repr) | |||
| self.assertEqual(result, eval(repr(result))) | |||
|
|
|||
| def test_conversion(self): | |||
| ts = Timestamp('2000-01-01') | |||
There was a problem hiding this comment.
add the issue as a comment here
|
trivial comment. looks good otherwise. you are picking up pieces from those other pr's yes? |
|
@shoyer yep. you had some good stuff in there IIRC. |
shoyer
added a commit
that referenced
this pull request
Jan 15, 2015
ENH: add Timestamp.to_datetime64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
Timestamp.to_datetime64()method to complement theTimedelta.to_timedelta64()method I added in #8884. It is a continuation of the aborted #8916.Arguably, there should also be the alias
Timestamp.valuesto complement the series property but I haven't added that yet.