Docstring: pd.to_datetime (issue #9107) #9189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The online documentation is indeed built automatically from docstrings, but it doesn't exclude code in the examples: So it would nice to add the output to these examples (as well as the missing output for the previous examples in this docstring). |
|
|
||
| Date that does not meet timestamp limitations: | ||
|
|
||
| >>> print pd.to_datetime('1300-01-01', format='%Y-%m-%d') |
There was a problem hiding this comment.
I would omit print here (repr() is called implicitly in the REPL).
|
@shoyer - OK, corrected |
shoyer
added a commit
that referenced
this pull request
Jan 4, 2015
Docstring: pd.to_datetime (issue #9107)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the issue "to_datetime returns NaT for old dates with coerce=True".
Do I understand correctly that online documentation is build automatically from docstrings? I.e. are there any other files to change?
Also it would be good to make a link to this section of "Caveats and Gotchas", but I'm not sure if the docstring is a good place to do this.