Skip to content

is_list_like() for to_excel, fixes #8188. #9181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

hunterowens
Copy link
Contributor

closes #8188

@jreback
Copy link
Contributor

jreback commented Jan 2, 2015

your comparison is going to be different as this is not a round-trippable format (e.g you will need to parse the return string and store it as a list in the expected frame).

  • need an addition to the doc-string on the proposed conversion
  • need a release note

@jreback jreback added Dtype Conversions Unexpected or buggy dtype conversions IO Excel read_excel, to_excel Enhancement labels Jan 2, 2015
@hunterowens
Copy link
Contributor Author

Okay, I will try and add those soon. Sorry about the incorrect test, I'm still learning on this stuff.

@jtratner
Copy link
Contributor

@hunterowens you might want to check out the performance impact of this as well, given that it has to be called on every single value of every cell that gets written.

@jreback
Copy link
Contributor

jreback commented Mar 25, 2015

@hunterowens working on this?

@jreback
Copy link
Contributor

jreback commented May 9, 2015

closing pls reopen if/when updated

@jreback jreback closed this May 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dtype Conversions Unexpected or buggy dtype conversions Enhancement IO Excel read_excel, to_excel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggested improvement: allow ExcelWriter to automatically convert lists and dict to strings
3 participants