BUG: Fix for extraneous default cell format in xlsxwriter files. #9171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| _skip_if_no_xlsxwriter() | ||
|
|
||
| import warnings | ||
| with warnings.catch_warnings(): |
There was a problem hiding this comment.
_skip_if_no_openpyxl() doesn't suffice here?
|
@jmcnamara pls add a release note. This is a bug fix? user noticeable? (so an API change?) pls make the appropriate entry. thxs. |
I'm not sure if it needs a release note entry since it doesn't really affect pandas. It it mainly to allow users to format columns in the encapsulated xlsxwriter object. If you think that it needs an entry I'll add one. Should it go in |
|
it needs a note - in v0.16.0 bug fix section |
Fix for issue in the xlsxwriter engine where is adds a default 'General' format to cells if no other format is applied. This isn't a bug, per se, but it prevents other row or column formatting. Closes #9167
|
|
merged via 07a5735 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue in the xlsxwriter engine where is adds a default
'General' format to cells if no other format is applied. This
isn't a bug, per se, but it prevents other row or column formatting.
closes #9167