Skip to content

PERF: use labels to find duplicates in multi-index #9125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

behzadnouri
Copy link
Contributor

-------------------------------------------------------------------------------
Test name                                    | head[ms] | base[ms] |  ratio   |
-------------------------------------------------------------------------------
multiindex_duplicated                        | 139.2883 | 469.6666 |   0.2966 |
-------------------------------------------------------------------------------
Test name                                    | head[ms] | base[ms] |  ratio   |
-------------------------------------------------------------------------------

Ratio < 1.0 means the target commit is faster then the baseline.
Seed used: 1234

Target [2b99b80] : use labels to identify duplicates in multi-index
Base   [0fe43a6] : Merge pull request #9120 from minrk/nbviewer-link

fix an nbviewer link in tutorials

@jreback
Copy link
Contributor

jreback commented Dec 21, 2014

this on top of #9061 ?

Parameters
----------
labels: sequance of arrays
Integers identifying levels at each location
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sequence

@behzadnouri
Copy link
Contributor Author

get_flat_ids is copy pasted from #9061. MultiIndex.is_unique has been re-factored.

@jreback
Copy link
Contributor

jreback commented Dec 22, 2014

ok, #9061 merged, so pls rebase this

@jreback jreback added Performance Memory or execution speed performance MultiIndex labels Dec 22, 2014
@jreback jreback added this to the 0.16.0 milestone Dec 22, 2014
@jreback
Copy link
Contributor

jreback commented Dec 22, 2014

pls add a release note as well

@behzadnouri
Copy link
Contributor Author

rebased and added release note. travis build all green.

@behzadnouri
Copy link
Contributor Author

@jreback actually i think it is better to have duplicated as a separate function as opposed to class method. so plz do not merge, and let me change the code.

@jreback
Copy link
Contributor

jreback commented Dec 22, 2014

@behzadnouri no prob. lmk

@behzadnouri
Copy link
Contributor Author

@jreback this is done!

@jreback
Copy link
Contributor

jreback commented Dec 23, 2014

merged via 8f4a321 thanks!

@jreback jreback closed this Dec 23, 2014
@behzadnouri behzadnouri deleted the dupl branch December 23, 2014 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MultiIndex Performance Memory or execution speed performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants