Remove bar line #9122
Merged
Remove bar line #9122
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAugspurger
force-pushed
the
remove-bar-line
branch
from
572c5c1 to
c2d194b
Compare
|
-1 in adding a parameter - this just looks like a bug |
|
Agreed, let's kill it. It's easy enough to add in manually afterwards. |
| @@ -29,6 +29,9 @@ Backwards incompatible API changes | |||
|
|
|||
| - ``Index.duplicated`` now returns `np.array(dtype=bool)` rather than `Index(dtype=object)` containing `bool` values. (:issue:`8875`) | |||
|
|
|||
| - Bar and horizontal bar plots no longer add a dashed line along the info axis. The prior style can be achieved with matplotlib's `axhline` or `axvline` | |||
| methods (:issue:`9088`). | |||
There was a problem hiding this comment.
no spaces needed as line breaks
|
minor doc issue. looks good. |
TomAugspurger
force-pushed
the
remove-bar-line
branch
from
c2d194b to
a9534ff
Compare
|
@TomAugspurger I think you can merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9088
Closes #7128
Votes on whether we should
.plotcontrol whether the line should be added.I vote for 1, but I can go either way.