-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG in read_csv skipping rows after a row with trailing spaces, #8983 #8984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -3070,6 +3070,13 @@ def test_trailing_spaces(self): | |||
header=None, delim_whitespace=True, | |||
skiprows=[0,1,2,3,5,6], skip_blank_lines=True) | |||
tm.assert_frame_equal(df, expected) | |||
# test skipping set of rows after a row with trailing spaces | |||
expected = pd.DataFrame({"A":[1., 5.1], "B":[2., np.nan], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls add the issue number as a comment
pls add the issue number into the same release note that dealt with this otherwise looks good ping when ready |
added the issue number to whatsnew/v0.15.2.txt and to test_parsers.py |
BUG in read_csv skipping rows after a row with trailing spaces, #8983
@selasley awesome! thanks for the fixes. not many want to delve into the c-parser! |
This may not be the appropriate place for this comment and you probably hear it often, but thank you for pandas. I converted some python scripts we wrote to plot our near-real time SOHO MTOF data on the web from numpy+matplotlib to pandas. The scripts are much easier to follow now and I was able to add a few features that would have been cumbersome to do with straight numpy. I'll see if I can do anything with 8985 and 6710. I believe there are still some bugs in read_csv with certain combinations of options. I'll work on fixing any that I can find as time allows. |
@selasley always appropriate for praise :) glad to see you are using it! and feel free to chime in on any issues...thanks again |
Update tokenizer.c to fix a BUG in read_csv skipping rows after tokenizing a row with trailing spaces, Closes #8983