Doc for GH 8946 #8952
Closed
Doc for GH 8946 #8952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d object dtype are allowed (previously would raise TypeError) (GH8938)
| * comparing a categorical Series to another categorical Series, when `categories` and `ordered` is | ||
| the same or | ||
| * comparing a categorical Series to a scalar. | ||
| * comparing equality (``==`` and ``!=``) to a scalar or a list-like object (list, Series, array, |
There was a problem hiding this comment.
Does it make sense to drop the "to a scalar" part so that this line reads
comparing equality (
==and!=) to a list-like object (list, Series, array, ...) ...
It looks like the scalar part is covered in your 3rd case. I'm behind on the issue, so I could be missing something.
There was a problem hiding this comment.
you are right, will push an update in a minute...
|
incorporated in #8946 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #8946