BUG: Option context applies on __enter__ #8925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -425,3 +425,27 @@ def f3(key): | |||
| options.c = 1 | |||
| self.assertEqual(len(holder), 1) | |||
|
|
|||
| def test_option_context_scope(self): | |||
| # Ensure that creating a context does not affect the existing | |||
| # environment as it is supposed to be used with the `with` statement. | |||
There was a problem hiding this comment.
Can you add here the original issue number?
There was a problem hiding this comment.
Added link to ticket. Thanks.
hkleynhans
force-pushed
the
fix/8514_option_context_with
branch
from
11615ce to
3053b52
Compare
Option context no longer overrides options when used outside a `with` statement. Added test TestConfig.test_option_config_scope Closes pandas-dev#8514
hkleynhans
force-pushed
the
fix/8514_option_context_with
branch
from
3053b52 to
f21539b
Compare
|
All issues were addressed. Thanks. |
|
Looking good for me! |
|
merging! |
jorisvandenbossche
added a commit
that referenced
this pull request
Nov 29, 2014
BUG: Option context applies on __enter__
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option context no longer overrides options when used outside a
withstatement.
Added test TestConfig.test_option_config_scope
Closes #8514