astype checks notnull Fixes: #8732 #8924
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2141,6 +2141,15 @@ def setUp(self): | |||
| self.simple = DataFrame(arr, columns=['one', 'two', 'three'], | |||
| index=['a', 'b', 'c']) | |||
|
|
|||
| def test_hasnulls(self): | |||
| df = tm.makeMissingDataframe() | |||
| self.assertEqual(df['A'].notnull().all(), False) | |||
There was a problem hiding this comment.
add the issue number as a comment here
|
needs a vbench for perf comparisons |
|
@jreback there are a lot of checks for different dtypes (datetime, timedelta, etc) in the |
|
I think the original purpose was to render object types safe (as in an actual python object) but needs some investigation |
|
You are right needs a bit more work. |
jreback
added
Strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in issue #8732 if there are no nulls, we skip the nan_safe bit.