WIP: add multi-multi index support to join #8898
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| labels.append(new_labels) | ||
| indexers.append(new_indexer) | ||
|
|
||
| import pdb; pdb.set_trace() |
There was a problem hiding this comment.
this caused our build to fail :)
|
you need to remove the NotImplemented from the test suite to see if it passes the tests: https://github.com/pydata/pandas/blob/master/pandas/tools/tests/test_merge.py#L1193 also, think about adding a couple of more tests to exercise this (e.g. say an empty frame with the proper index on the merging axis), maybe a couple of simple examples too. |
jreback
added
Algos
|
closing pls reopen if/when updated |
|
Any chance to reopen this issue? It would be really useful to have this feature in pandas |
|
@harisbal this is a pull-request to fix an issue. you can certainly build on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6360