Clarify encoding kwarg on to_csv #8857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| a string representing the encoding to use if the contents are | ||
| non-ascii, for python versions prior to 3 | ||
| A string representing the encoding to use in the output file, | ||
| defaults to 'ascii' on Python 2 and 'utf-8' on Python 3. |
There was a problem hiding this comment.
this actually defaults to the sys.encoding (which has those defaults) IIRC. maybe need someone non-us to verify this?
There was a problem hiding this comment.
I'm not sure on the semantics for Python 3, but for Python 2 the csv modules does ASCII only (or at least doesn't mention sys.encoding at all), not sure if we've changed the defaults internally.
There was a problem hiding this comment.
The default encoding is indeed ascii for py2 and utf-8 for py3. There is a way to change that but it involves quite a bit of magic: http://stackoverflow.com/questions/2276200/changing-default-encoding-of-python
jreback
added a commit
that referenced
this pull request
Nov 20, 2014
Clarify encoding kwarg on to_csv
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.