Skip to content

BUG: Defined .size attribute across NDFrame objects to provide compat with numpy 1.9.1 #8847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v0.15.2.txt
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ Bug Fixes




- Defined ``.size`` attribute across ``NDFrame`` objects to provide compat with numpy >= 1.9.1; buggy with ``np.array_split`` (:issue:`8846`)


- Skip testing of histogram plots for matplotlib <= 1.2 (:issue:`8648`).
Expand Down
5 changes: 5 additions & 0 deletions pandas/core/generic.py
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,11 @@ def ndim(self):
"Number of axes / array dimensions"
return self._data.ndim

@property
def size(self):
"number of elements in the NDFrame"
return np.prod(self.shape)

def _expand_axes(self, key):
new_axes = []
for k, ax in zip(key, self.axes):
Expand Down
19 changes: 17 additions & 2 deletions pandas/tests/test_generic.py
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,21 @@ def test_head_tail(self):
self._compare(o.head(-3), o.head(7))
self._compare(o.tail(-3), o.tail(7))


def test_size_compat(self):
# GH8846
# size property should be defined

o = self._construct(shape=10)
self.assertTrue(o.size == np.prod(o.shape))
self.assertTrue(o.size == 10**len(o.axes))

def test_split_compat(self):
# xref GH8846
o = self._construct(shape=10)
self.assertTrue(len(np.array_split(o,5)) == 5)
self.assertTrue(len(np.array_split(o,2)) == 2)

class TestSeries(tm.TestCase, Generic):
_typ = Series
_comparator = lambda self, x, y: assert_series_equal(x,y)
Expand Down Expand Up @@ -1422,8 +1437,8 @@ def test_equals(self):
self.assertTrue(a.equals(c))
self.assertTrue(a.equals(d))
self.assertFalse(a.equals(e))
self.assertTrue(e.equals(f))
self.assertTrue(e.equals(f))

def test_describe_raises(self):
with tm.assertRaises(NotImplementedError):
tm.makePanel().describe()
Expand Down